mash: Partially migrate ScreenOrientationController to ash/common.

mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb
Cr-Commit-Position: refs/heads/master@{#404906}

[msw, 2016-07-08 20:34:37]

Description was changed from

==========
mash: Partially migrate ScreenOrientationController to ash/common.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Partially migrate ScreenOrientationController to ash/common.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2016-07-08 20:53:52]

Description was changed from

==========
mash: Partially migrate ScreenOrientationController to ash/common.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2016-07-08 20:57:54]

Hey James, please take a look; thanks!
(sorry it's not easy to do in one swoop...)

[msw, 2016-07-08 20:57:59]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 20:58:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-08 21:21:18]

LGTM

[commit-bot: I haz the power, 2016-07-08 21:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 21:33:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-07-11 18:58:14]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 18:58:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 19:35:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 19:35:33]

Dry run: This issue passed the CQ dry run.

[msw, 2016-07-11 19:46:01]

Hey James, does the test file change look ok?

[jonross, 2016-07-11 19:48:13]

jonross@chromium.org changed reviewers:
+ jonross@chromium.org

[jonross, 2016-07-11 19:48:13]

https://codereview.chromium.org/2134753004/diff/40001/ash/content/display/scr...
File ash/content/display/screen_orientation_controller_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2134753004/diff/40001/ash/content/display/scr...
ash/content/display/screen_orientation_controller_chromeos_unittest.cc:303:
controller->OnWindowVisibilityChanging(window, false);
I'm a bit concerned that this is not being triggered

[msw, 2016-07-11 20:02:31]

https://codereview.chromium.org/2134753004/diff/40001/ash/content/display/scr...
File ash/content/display/screen_orientation_controller_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2134753004/diff/40001/ash/content/display/scr...
ash/content/display/screen_orientation_controller_chromeos_unittest.cc:303:
controller->OnWindowVisibilityChanging(window, false);
On 2016/07/11 19:48:13, jonross wrote:
> I'm a bit concerned that this is not being triggered

Might be async WmWindow behavior, or a plumbing issue. Any tips?

[jonross, 2016-07-11 20:10:58]

https://codereview.chromium.org/2134753004/diff/40001/ash/content/display/scr...
File ash/content/display/screen_orientation_controller_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2134753004/diff/40001/ash/content/display/scr...
ash/content/display/screen_orientation_controller_chromeos_unittest.cc:303:
controller->OnWindowVisibilityChanging(window, false);
On 2016/07/11 20:02:31, msw wrote:
> On 2016/07/11 19:48:13, jonross wrote:
> > I'm a bit concerned that this is not being triggered
> 
> Might be async WmWindow behavior, or a plumbing issue. Any tips?

ScreenOrientationController should become a listener of WmWindow once Lock is
called (line 296.) I'd look to see what's happening with WmWindow, to see if the
notification is being fired correctly.

[msw, 2016-07-11 21:53:10]

I'll have an update soon.

https://codereview.chromium.org/2134753004/diff/40001/ash/content/display/scr...
File ash/content/display/screen_orientation_controller_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2134753004/diff/40001/ash/content/display/scr...
ash/content/display/screen_orientation_controller_chromeos_unittest.cc:303:
controller->OnWindowVisibilityChanging(window, false);
On 2016/07/11 20:10:58, jonross wrote:
> On 2016/07/11 20:02:31, msw wrote:
> > On 2016/07/11 19:48:13, jonross wrote:
> > > I'm a bit concerned that this is not being triggered
> > 
> > Might be async WmWindow behavior, or a plumbing issue. Any tips?
> 
> ScreenOrientationController should become a listener of WmWindow once Lock is
> called (line 296.) I'd look to see what's happening with WmWindow, to see if
the
> notification is being fired correctly.

Thanks for pushing me to dig in; I'll need to implement
WmWindowObserver::OnWindowVisibilityChanged for this to work as it did; the
target visibility has updated before
WmWindowObserver::OnWindowVisibilityChanging is called... that should have ben
obvious to me earlier.

[msw, 2016-07-11 22:14:15]

Description was changed from

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2016-07-11 22:15:03]

Description was changed from

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[msw, 2016-07-11 22:17:06]

Added WmWindowObserver::OnWindowVisibilityChanged (very simple) and removed the
test changes. LMK if there are any more comments. TBR'ing Scott for chrome/* and
landing.

[msw, 2016-07-11 22:17:15]

The CQ bit was checked by msw@chromium.org

[msw, 2016-07-11 22:17:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2134753004/#ps60001
(title: "Add and use WmWindowObserver::OnWindowVisibilityChanged.")

[commit-bot: I haz the power, 2016-07-11 22:18:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 23:54:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 23:54:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-07-12 00:15:58]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:17:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 02:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 02:24:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-07-12 11:46:31]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-07-12 11:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 15:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 15:51:15]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jonross, 2016-07-12 15:51:44]

On 2016/07/12 15:51:15, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

LGTM. Thanks for hunting that down!

[msw, 2016-07-12 16:02:46]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-07-12 16:04:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 20:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:16:21]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-07-12 20:20:23]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:22:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-07-12 23:10:12]

The CQ bit was checked by msw@chromium.org

[msw, 2016-07-12 23:10:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, jonross@chromium.org
Link to the patchset: https://codereview.chromium.org/2134753004/#ps80001
(title: "Sync and rebase.")

[commit-bot: I haz the power, 2016-07-12 23:12:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:22:33]

Description was changed from

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-07-13 02:22:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-13 02:22:58]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 02:25:33]

Description was changed from

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb
Cr-Commit-Position: refs/heads/master@{#404906}
==========

[commit-bot: I haz the power, 2016-07-13 02:25:35]

Patchset 5 (id:??) landed as
https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb
Cr-Commit-Position: refs/heads/master@{#404906}