[metrics] Change rangeOfInterest logic of all metrics to include extrema

[metrics] Change rangeOfInterest logic of all metrics to include extrema

This patch modifies all TBMv2 metrics in tracing/metrics to treat the
optional rangeOfInterest parameter as inclusive, i.e. to include its
maximum and minimum.

For example, given a range of interest [10s, 20s], user expectations
would/wouldn't be included in the calculation of the responsiveness
metric as follows:

                   rangeOfInterest                       Included
                   10 <-------> 20                    Before : After     
  ------------------+-----------+----------------->  ........:......
  |<-u. exp.->|     :           :                       n    :   n
        |<-u. exp.->|           :                       n    :   Y (!)
              |<-u. exp.->|     :                       Y    :   Y
                    |<-u. exp.->|                       Y    :   Y
                    :     |<-u. exp.->|                 Y    :   Y
                    :           |<-u. exp.->|           n    :   Y (!)
                    :           :     |<-u. exp.->|     n    :   n

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b8e157091d005b037430055b11b13c2b98982231

[petrcermak, 2016-07-08 15:30:14]

Description was changed from

==========
[metrics] Change rangeOfInterest logic of all metrics to include extrema

This patch modifies
==========

to

==========
[metrics] Change rangeOfInterest logic of all metrics to include extrema

This patch modifies all TBMv2 metrics in tracing/metrics to treat the
optional rangeOfInterest parameter as inclusive, i.e. to include its
maximum and minimum.

For example, given a range of interest [10s, 20s], user expectations
would/wouldn't be included in the calculation of the responsiveness
metric as follows:

                   rangeOfInterest                       Included
                   10 <-------> 20                    Before : After     
  ------------------+-----------+----------------->  ........:......
  |<-u. exp.->|     :           :                       n    :   n
        |<-u. exp.->|           :                       n    :   Y (!)
              |<-u. exp.->|     :                       Y    :   Y
                    |<-u. exp.->|                       Y    :   Y
                    :     |<-u. exp.->|                 Y    :   Y
                    :           |<-u. exp.->|           n    :   Y (!)
                    :           :     |<-u. exp.->|     n    :   n
==========

[petrcermak, 2016-07-08 15:31:09]

petrcermak@chromium.org changed reviewers:
+ benjhayden@chromium.org

[petrcermak, 2016-07-08 15:31:09]

PTAL.

Thanks,
Petr

[benjhayden, 2016-07-08 16:06:05]

lgtm

[petrcermak, 2016-07-08 16:08:15]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-07-08 16:08:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 17:51:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 17:51:02]

Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[petrcermak, 2016-07-11 07:25:07]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-07-11 07:25:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 07:49:52]

Description was changed from

==========
[metrics] Change rangeOfInterest logic of all metrics to include extrema

This patch modifies all TBMv2 metrics in tracing/metrics to treat the
optional rangeOfInterest parameter as inclusive, i.e. to include its
maximum and minimum.

For example, given a range of interest [10s, 20s], user expectations
would/wouldn't be included in the calculation of the responsiveness
metric as follows:

                   rangeOfInterest                       Included
                   10 <-------> 20                    Before : After     
  ------------------+-----------+----------------->  ........:......
  |<-u. exp.->|     :           :                       n    :   n
        |<-u. exp.->|           :                       n    :   Y (!)
              |<-u. exp.->|     :                       Y    :   Y
                    |<-u. exp.->|                       Y    :   Y
                    :     |<-u. exp.->|                 Y    :   Y
                    :           |<-u. exp.->|           n    :   Y (!)
                    :           :     |<-u. exp.->|     n    :   n
==========

to

==========
[metrics] Change rangeOfInterest logic of all metrics to include extrema

This patch modifies all TBMv2 metrics in tracing/metrics to treat the
optional rangeOfInterest parameter as inclusive, i.e. to include its
maximum and minimum.

For example, given a range of interest [10s, 20s], user expectations
would/wouldn't be included in the calculation of the responsiveness
metric as follows:

                   rangeOfInterest                       Included
                   10 <-------> 20                    Before : After     
  ------------------+-----------+----------------->  ........:......
  |<-u. exp.->|     :           :                       n    :   n
        |<-u. exp.->|           :                       n    :   Y (!)
              |<-u. exp.->|     :                       Y    :   Y
                    |<-u. exp.->|                       Y    :   Y
                    :     |<-u. exp.->|                 Y    :   Y
                    :           |<-u. exp.->|           n    :   Y (!)
                    :           :     |<-u. exp.->|     n    :   n

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-11 07:49:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...