Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2134733002: Copy Dart-configuration detection from dart script to pub. (Closed)

Created:
4 years, 5 months ago by floitsch
Modified:
4 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Copy Dart-configuration detection from dart script to pub. Fixes #26621. BUG= http://dartbug.com/26621 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/9a851032c9205170c710419cb05c9d54d86591a2

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M sdk/bin/pub View 1 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
floitsch
4 years, 5 months ago (2016-07-08 13:46:36 UTC) #3
Bill Hesse
LGTM.
4 years, 5 months ago (2016-07-08 14:04:54 UTC) #4
floitsch
4 years, 5 months ago (2016-07-08 14:23:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9a851032c9205170c710419cb05c9d54d86591a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698