Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine.h

Issue 213473008: [SyncFS] Split SyncEngine and SyncEngineContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/sync_engine.h
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine.h b/chrome/browser/sync_file_system/drive_backend/sync_engine.h
index 892edd4d5689e23cb019da3a1854883f546a81d5..0f52d2850be9abdd4d69d0e70e0505253b3ab391 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_engine.h
+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine.h
@@ -48,8 +48,7 @@ class SyncEngine : public RemoteFileSyncService,
public SyncTaskManager::Client,
public drive::DriveNotificationObserver,
public drive::DriveServiceObserver,
- public net::NetworkChangeNotifier::NetworkChangeObserver,
- public SyncEngineContext {
+ public net::NetworkChangeNotifier::NetworkChangeObserver {
public:
typedef Observer SyncServiceObserver;
@@ -132,11 +131,11 @@ class SyncEngine : public RemoteFileSyncService,
net::NetworkChangeNotifier::ConnectionType type) OVERRIDE;
// SyncEngineContext overrides.
tzik 2014/03/27 07:41:03 drop this comment?
peria 2014/03/27 10:14:37 Done.
- virtual drive::DriveServiceInterface* GetDriveService() OVERRIDE;
- virtual drive::DriveUploaderInterface* GetDriveUploader() OVERRIDE;
- virtual MetadataDatabase* GetMetadataDatabase() OVERRIDE;
- virtual RemoteChangeProcessor* GetRemoteChangeProcessor() OVERRIDE;
- virtual base::SequencedTaskRunner* GetBlockingTaskRunner() OVERRIDE;
+ drive::DriveServiceInterface* GetDriveService();
+ drive::DriveUploaderInterface* GetDriveUploader();
+ MetadataDatabase* GetMetadataDatabase();
+ RemoteChangeProcessor* GetRemoteChangeProcessor();
+ base::SequencedTaskRunner* GetBlockingTaskRunner();
private:
friend class DriveBackendSyncTest;
@@ -179,13 +178,8 @@ class SyncEngine : public RemoteFileSyncService,
base::FilePath base_dir_;
base::FilePath temporary_file_dir_;
- scoped_refptr<base::SequencedTaskRunner> task_runner_;
leveldb::Env* env_override_;
- scoped_ptr<drive::DriveServiceInterface> drive_service_;
- scoped_ptr<drive::DriveUploaderInterface> drive_uploader_;
- scoped_ptr<MetadataDatabase> metadata_database_;
-
// These external services are not owned by SyncEngine.
// The owner of the SyncEngine is responsible for their lifetime.
// I.e. the owner should declare the dependency explicitly by calling
@@ -211,6 +205,7 @@ class SyncEngine : public RemoteFileSyncService,
scoped_ptr<SyncTaskManager> task_manager_;
+ scoped_ptr<SyncEngineContext> context_;
base::WeakPtrFactory<SyncEngine> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(SyncEngine);

Powered by Google App Engine
This is Rietveld 408576698