Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc

Issue 213473008: [SyncFS] Split SyncEngine and SyncEngineContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc b/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
index ef5dd95975dba211ddaad2e5ea62dec610acebed..3c484d6f9d7b3440b4c6360297085642ca2ad380 100644
--- a/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
+++ b/chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc
@@ -44,8 +44,7 @@ fileapi::FileSystemURL URL(const GURL& origin,
} // namespace
-class ConflictResolverTest : public testing::Test,
- public SyncEngineContext {
+class ConflictResolverTest : public testing::Test {
public:
typedef FakeRemoteChangeProcessor::URLToFileChangesMap URLToFileChangesMap;
@@ -57,18 +56,24 @@ class ConflictResolverTest : public testing::Test,
ASSERT_TRUE(database_dir_.CreateUniqueTempDir());
in_memory_env_.reset(leveldb::NewMemEnv(leveldb::Env::Default()));
- fake_drive_service_.reset(new FakeDriveServiceWrapper);
- ASSERT_TRUE(fake_drive_service_->LoadAccountMetadataForWapi(
+ scoped_ptr<FakeDriveServiceWrapper>
+ fake_drive_service(new FakeDriveServiceWrapper);
+ ASSERT_TRUE(fake_drive_service->LoadAccountMetadataForWapi(
"sync_file_system/account_metadata.json"));
- ASSERT_TRUE(fake_drive_service_->LoadResourceListForWapi(
+ ASSERT_TRUE(fake_drive_service->LoadResourceListForWapi(
"gdata/empty_feed.json"));
- drive_uploader_.reset(new FakeDriveUploader(fake_drive_service_.get()));
+ scoped_ptr<drive::DriveUploaderInterface>
+ drive_uploader(new FakeDriveUploader(fake_drive_service.get()));
fake_drive_helper_.reset(new FakeDriveServiceHelper(
- fake_drive_service_.get(), drive_uploader_.get(),
- kSyncRootFolderTitle));
+ fake_drive_service.get(), drive_uploader.get(), kSyncRootFolderTitle));
fake_remote_change_processor_.reset(new FakeRemoteChangeProcessor);
+ context_.reset(new SyncEngineContext(
+ fake_drive_service.PassAs<drive::DriveServiceInterface>(),
+ drive_uploader.Pass(), base::MessageLoopProxy::current()));
+ context_->SetRemoteChangeProcessor(fake_remote_change_processor_.get());
+
RegisterSyncableFileSystem();
sync_task_manager_.reset(new SyncTaskManager(
@@ -83,55 +88,33 @@ class ConflictResolverTest : public testing::Test,
RevokeSyncableFileSystem();
fake_remote_change_processor_.reset();
- metadata_database_.reset();
fake_drive_helper_.reset();
- drive_uploader_.reset();
- fake_drive_service_.reset();
+ context_.reset();
base::RunLoop().RunUntilIdle();
}
void InitializeMetadataDatabase() {
- SyncEngineInitializer initializer(this,
+ SyncEngineInitializer initializer(context_.get(),
base::MessageLoopProxy::current(),
- fake_drive_service_.get(),
+ context_->GetDriveService(),
database_dir_.path(),
in_memory_env_.get());
SyncStatusCode status = SYNC_STATUS_UNKNOWN;
initializer.RunSequential(CreateResultReceiver(&status));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(SYNC_STATUS_OK, status);
- metadata_database_ = initializer.PassMetadataDatabase();
+ context_->SetMetadataDatabase(initializer.PassMetadataDatabase());
}
void RegisterApp(const std::string& app_id,
const std::string& app_root_folder_id) {
SyncStatusCode status = SYNC_STATUS_FAILED;
- metadata_database_->RegisterApp(app_id, app_root_folder_id,
- CreateResultReceiver(&status));
+ context_->GetMetadataDatabase()->RegisterApp(app_id, app_root_folder_id,
+ CreateResultReceiver(&status));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(SYNC_STATUS_OK, status);
}
- virtual drive::DriveServiceInterface* GetDriveService() OVERRIDE {
- return fake_drive_service_.get();
- }
-
- virtual drive::DriveUploaderInterface* GetDriveUploader() OVERRIDE {
- return drive_uploader_.get();
- }
-
- virtual MetadataDatabase* GetMetadataDatabase() OVERRIDE {
- return metadata_database_.get();
- }
-
- virtual RemoteChangeProcessor* GetRemoteChangeProcessor() OVERRIDE {
- return fake_remote_change_processor_.get();
- }
-
- virtual base::SequencedTaskRunner* GetBlockingTaskRunner() OVERRIDE {
- return base::MessageLoopProxy::current().get();
- }
-
protected:
std::string CreateSyncRoot() {
std::string sync_root_folder_id;
@@ -170,7 +153,7 @@ class ConflictResolverTest : public testing::Test,
const std::string& parent_folder_id,
const std::string& file_id) {
google_apis::GDataErrorCode error = google_apis::GDATA_OTHER_ERROR;
- fake_drive_service_->AddResourceToDirectory(
+ context_->GetDriveService()->AddResourceToDirectory(
parent_folder_id, file_id,
CreateResultReceiver(&error));
base::RunLoop().RunUntilIdle();
@@ -193,7 +176,8 @@ class ConflictResolverTest : public testing::Test,
SyncStatusCode RunRemoteToLocalSyncer() {
SyncStatusCode status = SYNC_STATUS_UNKNOWN;
- scoped_ptr<RemoteToLocalSyncer> syncer(new RemoteToLocalSyncer(this));
+ scoped_ptr<RemoteToLocalSyncer> syncer(
+ new RemoteToLocalSyncer(context_.get()));
syncer->RunSequential(CreateResultReceiver(&status));
base::RunLoop().RunUntilIdle();
return status;
@@ -207,7 +191,8 @@ class ConflictResolverTest : public testing::Test,
if (file_change.IsAddOrUpdate())
CreateTemporaryFileInDir(database_dir_.path(), &local_path);
scoped_ptr<LocalToRemoteSyncer> syncer(new LocalToRemoteSyncer(
- this, SyncFileMetadata(file_change.file_type(), 0, base::Time()),
+ context_.get(),
+ SyncFileMetadata(file_change.file_type(), 0, base::Time()),
file_change, local_path, url));
syncer->RunSequential(CreateResultReceiver(&status));
base::RunLoop().RunUntilIdle();
@@ -224,7 +209,7 @@ class ConflictResolverTest : public testing::Test,
SyncStatusCode RunConflictResolver() {
SyncStatusCode status = SYNC_STATUS_UNKNOWN;
- ConflictResolver resolver(this);
+ ConflictResolver resolver(context_.get());
resolver.RunSequential(CreateResultReceiver(&status));
base::RunLoop().RunUntilIdle();
return status;
@@ -234,7 +219,7 @@ class ConflictResolverTest : public testing::Test,
SyncStatusCode status = SYNC_STATUS_UNKNOWN;
sync_task_manager_->ScheduleSyncTask(
FROM_HERE,
- scoped_ptr<SyncTask>(new ListChangesTask(this)),
+ scoped_ptr<SyncTask>(new ListChangesTask(context_.get())),
SyncTaskManager::PRIORITY_MED,
CreateResultReceiver(&status));
base::RunLoop().RunUntilIdle();
@@ -274,10 +259,8 @@ class ConflictResolverTest : public testing::Test,
base::ScopedTempDir database_dir_;
scoped_ptr<leveldb::Env> in_memory_env_;
- scoped_ptr<FakeDriveServiceWrapper> fake_drive_service_;
- scoped_ptr<FakeDriveUploader> drive_uploader_;
+ scoped_ptr<SyncEngineContext> context_;
scoped_ptr<FakeDriveServiceHelper> fake_drive_helper_;
- scoped_ptr<MetadataDatabase> metadata_database_;
scoped_ptr<FakeRemoteChangeProcessor> fake_remote_change_processor_;
scoped_ptr<SyncTaskManager> sync_task_manager_;

Powered by Google App Engine
This is Rietveld 408576698