Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 213473005: Remove PlatformFile from profile_browsertest (Closed)

Created:
6 years, 9 months ago by rvargas (doing something else)
Modified:
6 years, 8 months ago
Reviewers:
cmp, DaveMoore
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Remove PlatformFile from profile_browsertest BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/profiles/profile_browsertest.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
rvargas (doing something else)
PTAL
6 years, 9 months ago (2014-03-27 01:35:41 UTC) #1
DaveMoore
lgtm
6 years, 9 months ago (2014-03-27 14:23:31 UTC) #2
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 9 months ago (2014-03-27 19:34:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/213473005/1
6 years, 9 months ago (2014-03-27 19:36:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 01:13:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136560
6 years, 9 months ago (2014-03-28 01:13:41 UTC) #6
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 9 months ago (2014-03-28 01:26:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/213473005/1
6 years, 9 months ago (2014-03-28 01:28:52 UTC) #8
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:36:49 UTC) #9
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:40:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/213473005/1
6 years, 8 months ago (2014-03-30 16:41:26 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:19:52 UTC) #12
Message was sent while issue was closed. 
Change committed as 260441

Powered by Google App Engine
This is Rietveld 408576698