tools/ignition/linux_perf_report.py - Issue 2134703002: [Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/ignition/linux_perf_report.py

Issue 2134703002: [Interpreter] Support Linux perf >= 4.1 in linux_perf_report.py. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/ignition/linux_perf_report.py

diff --git a/tools/ignition/linux_perf_report.py b/tools/ignition/linux_perf_report.py

index fbf562c2abe9b699de7feb47b09446c90c9b19a2..2d901d518625ace5ebb20883219358fd09ac2d0c 100755

--- a/tools/ignition/linux_perf_report.py

+++ b/tools/ignition/linux_perf_report.py

@@ -97,7 +97,7 @@ def collapsed_callchains_generator(perf_stream, show_all=False,

if skip_until_end_of_chain:

continue

- symbol = line.split(" ", 1)[1]

+ symbol = line.split(" ", 1)[1].split("+", 1)[0]

rmcilroy 2016/07/08 15:17:57 nit - add a comment on that the split("+... part i

Stefano Sanfilippo 2016/07/08 15:57:57 Done.

if not show_full_signatures:

symbol = strip_function_parameters(symbol)

current_chain.append(symbol)

@@ -204,7 +204,7 @@ def parse_command_line():

def main():

program_options = parse_command_line()

- perf = subprocess.Popen(["perf", "script", "-f", "ip,sym",

+ perf = subprocess.Popen(["perf", "script", "--fields", "ip,sym",

"-i", program_options.perf_filename],

stdout=subprocess.PIPE)

« no previous file with comments | « no previous file | no next file » | no next file with comments »