appengine/cmd/milo/settings/funcs.go - Issue 2134673003: milo: buildbucket builer view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/milo/settings/funcs.go

Issue 2134673003: milo: buildbucket builer view (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: rebased and regenerated expectations Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cmd/milo/settings/funcs.go

diff --git a/appengine/cmd/milo/settings/funcs.go b/appengine/cmd/milo/settings/funcs.go

index d91a512dbc2c8c0a9fe089b8adf1f21d35570f26..acca4c5e09060a6194572ff2d7f6961df8c9cf9f 100644

--- a/appengine/cmd/milo/settings/funcs.go

+++ b/appengine/cmd/milo/settings/funcs.go

@@ -113,8 +113,13 @@ var linkifyTemplate = template.Must(

// linkify turns a resp.Link struct into a canonical link.

func linkify(link *resp.Link) template.HTML {

+ if link == nil {

+ return ""

+ }

buf := bytes.Buffer{}

- linkifyTemplate.Execute(&buf, link)

+ if err := linkifyTemplate.Execute(&buf, link); err != nil {

+ panic(err)

+ }

return template.HTML(buf.Bytes())

}