Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: appengine/cmd/milo/frontend/templates/buildbot/pages/builder.html

Issue 2134673003: milo: buildbucket builer view (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: rebased and regenerated expectations Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/cmd/milo/frontend/templates/buildbot/pages/builder.html
diff --git a/appengine/cmd/milo/frontend/templates/buildbot/pages/builder.html b/appengine/cmd/milo/frontend/templates/buildbot/pages/builder.html
index 32b67b52c9fd9ddc246d073144120521468fb9c5..338936706fbd645def55cc30e0974f68f09721bb 100644
--- a/appengine/cmd/milo/frontend/templates/buildbot/pages/builder.html
+++ b/appengine/cmd/milo/frontend/templates/buildbot/pages/builder.html
@@ -1,10 +1,10 @@
-{{define "title"}}Builder [[name here]]{{end}}
+{{define "title"}}Builder {{.Builder.Name}}{{end}}
{{define "head"}}{{end}}
{{define "body"}}
{{ if .Builder.CurrentBuilds }}
- <h2>Current Builds:</h2>
+ <h2>Current Builds ({{len .Builder.CurrentBuilds}}):</h2>
<ul>
{{ range .Builder.CurrentBuilds }}
<li>{{ .Link | linkify }}
@@ -18,7 +18,7 @@
{{ end }}
{{ if .Builder.PendingBuilds }}
- <h2>Pending Build Requests:</h2>
+ <h2>Pending Build Requests ({{len .Builder.PendingBuilds}}):</h2>
<ul>
{{ range .Builder.PendingBuilds }}
<li><small>({{ .PendingTime.Started | localTime "" }}, waiting {{ .PendingTime.Duration | humanDuration }})</small>
@@ -26,7 +26,6 @@
{{ $nb := len .Blame }}
{{ if lt $nb 4 }}
{{ range $i, $c := .Blame }}
- {{ .Revision }}
(<a href="{{ .CommitURL }}">{{ .AuthorEmail }}</a>)
{{ if ne $i (sub $nb 1) }},{{ end }}
{{ end }}
@@ -62,6 +61,8 @@
<td class="success">Success</td>
{{ else if eq .Status.String "Failure" }}
<td class="failure">Failed</td>
+ {{ else if eq .Status.String "InfraFailure" }}
+ <td class="exception">Infra Failure</td>
{{ else }}
<td> {{ .Status.String }} </td>
{{ end }}
@@ -70,15 +71,23 @@
{{ $nb := len .Blame }}
{{ if lt $nb 4 }}
{{ range $i, $c := .Blame }}
- {{ .Revision }}
{{ if gt $i 0 }},{{ end }}
- (<a href="{{ .CommitURL }}">{{ .AuthorEmail }}</a>)
+ {{ if .Changelist }}
+ {{ .Changelist | linkify }}
+ {{ if .AuthorEmail }}
+ by {{ .AuthorEmail }}
+ {{ end }}
+ {{ else }}
+ (<a href="{{ .CommitURL }}">{{ .AuthorEmail }}</a>)
+ {{ end }}
{{ end }}
{{ else }}
({{ $nb }} changes)
{{ end }}
</td>
- <td class="left">{{ .Text }}</td>
+ <td class="left">
+ {{ .Text }}
+ </td>
</tr>
{{ end }}
</table>
« no previous file with comments | « appengine/cmd/milo/frontend/templates/bootstrap/pages/builder.html ('k') | appengine/cmd/milo/frontend/testdata/buildbucket » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698