Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3065)

Unified Diff: appengine/cmd/milo/buildbucket/properties.go

Issue 2134673003: milo: buildbucket builer view (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: rebased and regenerated expectations Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/cmd/milo/buildbucket/properties.go
diff --git a/appengine/cmd/milo/buildbucket/properties.go b/appengine/cmd/milo/buildbucket/properties.go
new file mode 100644
index 0000000000000000000000000000000000000000..34e5f85489f326be37de754fa517b5443f4a1b29
--- /dev/null
+++ b/appengine/cmd/milo/buildbucket/properties.go
@@ -0,0 +1,72 @@
+// Copyright 2016 The LUCI Authors. All rights reserved.
+// Use of this source code is governed under the Apache License, Version 2.0
+// that can be found in the LICENSE file.
+
+package buildbucket
+
+import (
+ "bytes"
+ "strconv"
+)
+
+// This file is about buildbucket build params in the format supported by
+// Buildbot.
+
+// properties is well-established build properties.
+type properties struct {
+ PatchStorage string `json:"patch_storage"` // e.g. "rietveld", "gerrit"
+
+ RietveldURL string `json:"rietveld"` // e.g. "https://codereview.chromium.org"
+ Issue number `json:"issue"` // e.g. 2127373005
+ PatchSet number `json:"patchset"` // e.g. 40001
+
+ GerritURL string `json:"gerrit"` // e.g. "https://chromium-review.googlesource.com"
+ GerritChangeNumber int `json:"event.change.number"` // e.g. 358171
+ GerritChangeID string `json:"event.change.id"` // e.g. "infra%2Finfra~master~Iee05b76799d577d491f533b8acaa4560ac14a806"
+ GerritChangeURL string `json:"event.change.url"` // e.g. "https://chromium-review.googlesource.com/#/c/358171"
+ GerritPatchRef string `json:"event.patchSet.ref"` // e.g. "refs/changes/71/358171/2"
+
+ Revision string `json:"revision"` // e.g. "0b04861933367c62630751702c84fd64bc3caf6f"
+ BlameList []string `json:"blamelist"` // e.g. ["someone@chromium.org"]
+
+ // Fields below are present only in ResultDetails.
+
+ GotRevision string `json:"got_revision"` // e.g. "0b04861933367c62630751702c84fd64bc3caf6f"
+ BuildNumber int `json:"buildnumber"` // e.g. 3021
+}
+
+// number is an integer that supports JSON unmarshalling from a string.
+type number int
+
+// UnmarshalJSON parses data as an integer, whether data is a number or string.
+func (n *number) UnmarshalJSON(data []byte) error {
+ data = bytes.Trim(data, `"`)
+ num, err := strconv.Atoi(string(data))
+ if err == nil {
+ *n = number(num)
+ }
+ return err
+}
+
+// change is used in "changes" buildbucket parameters; supported by buildbot
+// See https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/master/buildbucket/README.md#Build-parameters
+type change struct {
+ Author struct{ Email string }
+}
+
+// buildParameters is contents of "parameters_json" buildbucket build field
+// in the format supported by Buildbot, see
+// // See https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/master/buildbucket/README.md#Build-parameters
+//
+// Buildbucket is not aware of this format, but majority of chrome-infra is.
+type buildParameters struct {
+ BuilderName string `json:"builder_name"`
+ Properties properties
+ Changes []change
+}
+
+// resultDetails is contents of "result_details_json" buildbucket build field
+// in the format supported by Buildbot.
+type resultDetails struct {
+ Properties properties
+}

Powered by Google App Engine
This is Rietveld 408576698