Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 2134653003: [Extensions] Update TabHelper to use ExtensionId (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update TabHelper to use ExtensionId This was suggested in https://codereview.chromium.org/2103663002, but I held off because of the bloat of including extension.h. That's no longer the case with ExtensionId in its own header. BUG=None Committed: https://crrev.com/d8076cd6a8a842a7aec79fa82b14eaa0aea66410 Cr-Commit-Position: refs/heads/master@{#404523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/extensions/tab_helper.h View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 7 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Following up on this. :)
4 years, 5 months ago (2016-07-08 22:15:47 UTC) #2
lazyboy
lgtm
4 years, 5 months ago (2016-07-08 22:19:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134653003/1
4 years, 5 months ago (2016-07-08 22:25:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 23:06:14 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:08:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8076cd6a8a842a7aec79fa82b14eaa0aea66410
Cr-Commit-Position: refs/heads/master@{#404523}

Powered by Google App Engine
This is Rietveld 408576698