Issue 2134653002: Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently

Issue 2134653002: Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently (Closed)

Created:
4 years, 5 months ago by keishi

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently When JS iteratively constructs a DOM tree containing form controls, didAssociateFormControlsTimer was fireing for every iteration, causing a massive slow down. BUG=614856 Review-Url: https://codereview.chromium.org/2055693002 Cr-Commit-Position: refs/heads/master@{#404083} (cherry picked from commit 6e1c00f9b9656319829c290a280b5ffb07bc4d1a) Committed: https://chromium.googlesource.com/chromium/src/+/e0058d0fbb5c813090e00fdea134c6ba7c493a9e

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -6 lines)			Patch
M	chrome/renderer/autofill/autofill_renderer_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/autofill/password_generation_agent_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/chrome_render_view_test.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/chrome_render_view_test.cc	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	components/autofill/content/renderer/autofill_agent.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/Document.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

keishi

4 years, 5 months ago (2016-07-08 10:09:10 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e0058d0fbb5c813090e00fdea134c6ba7c493a9e (tree was closed).