Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2134633002:
media: vea unittest: fix gyp link issue on linux (Closed)
|
Created:
4 years, 5 months ago by llandwerlin-old Modified:
4 years, 5 months ago Reviewers:
chcunningham CC:
chromium-reviews, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia: vea unittest: fix gyp link issue on linux
Unable to find gfx::NumberOfPlanesForBufferFormat symbol :
media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)'
BUG=none
TEST=verify that video_encode_accelerator_unittest links successfully
Committed: https://crrev.com/5ed2e9aff99030871015ceb3ea12afa6bad61a2f
Cr-Commit-Position: refs/heads/master@{#405117}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 25 (12 generated)
lionel.g.landwerlin@intel.com changed reviewers: + chcunningham@chromium.org
chcunningham@: PTAL
Description was changed from ========== media: vea unittest: fix link issue Unable to find gfx::NumberOfPlanesForBufferFormat symbol : media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)' BUG=none TEST=verify that video_encode_accelerator_unittest links successfully ========== to ========== media: vea unittest: fix link issue on linux Unable to find gfx::NumberOfPlanesForBufferFormat symbol : media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)' BUG=none TEST=verify that video_encode_accelerator_unittest links successfully ==========
LGTM % doing the same update for GN https://codereview.chromium.org/2134633002/diff/1/media/media_gpu.gypi File media/media_gpu.gypi (right): https://codereview.chromium.org/2134633002/diff/1/media/media_gpu.gypi#newcode14 media/media_gpu.gypi:14: '../ui/gfx/gfx.gyp:gfx', Should you add the same to //src/media/gpu/BUILD.gn ?
https://codereview.chromium.org/2134633002/diff/1/media/media_gpu.gypi File media/media_gpu.gypi (right): https://codereview.chromium.org/2134633002/diff/1/media/media_gpu.gypi#newcode14 media/media_gpu.gypi:14: '../ui/gfx/gfx.gyp:gfx', On 2016/07/08 21:40:46, chcunningham wrote: > Should you add the same to //src/media/gpu/BUILD.gn ? I didn't have any issue building the test with GN. It seems it's already there : https://cs.chromium.org/chromium/src/media/gpu/BUILD.gn?sq=package:chromium&l...
Description was changed from ========== media: vea unittest: fix link issue on linux Unable to find gfx::NumberOfPlanesForBufferFormat symbol : media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)' BUG=none TEST=verify that video_encode_accelerator_unittest links successfully ========== to ========== media: vea unittest: fix gyp link issue on linux Unable to find gfx::NumberOfPlanesForBufferFormat symbol : media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)' BUG=none TEST=verify that video_encode_accelerator_unittest links successfully ==========
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lionel.g.landwerlin@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== media: vea unittest: fix gyp link issue on linux Unable to find gfx::NumberOfPlanesForBufferFormat symbol : media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)' BUG=none TEST=verify that video_encode_accelerator_unittest links successfully ========== to ========== media: vea unittest: fix gyp link issue on linux Unable to find gfx::NumberOfPlanesForBufferFormat symbol : media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)' BUG=none TEST=verify that video_encode_accelerator_unittest links successfully ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== media: vea unittest: fix gyp link issue on linux Unable to find gfx::NumberOfPlanesForBufferFormat symbol : media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)' BUG=none TEST=verify that video_encode_accelerator_unittest links successfully ========== to ========== media: vea unittest: fix gyp link issue on linux Unable to find gfx::NumberOfPlanesForBufferFormat symbol : media/gpu/vaapi_wrapper.cc:634: error: undefined reference to 'gfx::NumberOfPlanesForBufferFormat(gfx::BufferFormat)' BUG=none TEST=verify that video_encode_accelerator_unittest links successfully Committed: https://crrev.com/5ed2e9aff99030871015ceb3ea12afa6bad61a2f Cr-Commit-Position: refs/heads/master@{#405117} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5ed2e9aff99030871015ceb3ea12afa6bad61a2f Cr-Commit-Position: refs/heads/master@{#405117} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
