Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2134623002: service worker: Add crash keys for OnMessageReceived crash (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Add crash keys for OnMessageReceived crash We don't know why this crash is happening. One theory we timed out a request, removed the listener, sent a stop command, and meanwhile the response came back from the worker. In that case we should see STOPPING or STOPPED status. Also, log the IPC type for more clues. BUG=625040 Committed: https://crrev.com/678557d52c9cf757fd2759067131418bb88de5e4 Cr-Commit-Position: refs/heads/master@{#404414}

Patch Set 1 #

Patch Set 2 : crash_key #

Total comments: 2

Patch Set 3 : blimp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1 line) Patch
M blimp/engine/app/blimp_engine_crash_keys.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 3 chunks +58 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
falken
Please review.
4 years, 5 months ago (2016-07-08 09:11:53 UTC) #3
falken
rsesek: crash keys nhiroki: service worker
4 years, 5 months ago (2016-07-08 09:12:09 UTC) #4
nhiroki
lgtm
4 years, 5 months ago (2016-07-08 09:45:04 UTC) #5
falken
rsesek: please also hit the CQ checkbox if it lg to you, I hope to ...
4 years, 5 months ago (2016-07-08 14:44:54 UTC) #6
Robert Sesek
https://codereview.chromium.org/2134623002/diff/20001/chrome/common/crash_keys.cc File chrome/common/crash_keys.cc (right): https://codereview.chromium.org/2134623002/diff/20001/chrome/common/crash_keys.cc#newcode93 chrome/common/crash_keys.cc:93: // //blimp/engine/app/blimp_engine_crash_keys.cc Need to do this too.
4 years, 5 months ago (2016-07-08 15:00:20 UTC) #7
falken
thanks https://codereview.chromium.org/2134623002/diff/20001/chrome/common/crash_keys.cc File chrome/common/crash_keys.cc (right): https://codereview.chromium.org/2134623002/diff/20001/chrome/common/crash_keys.cc#newcode93 chrome/common/crash_keys.cc:93: // //blimp/engine/app/blimp_engine_crash_keys.cc On 2016/07/08 15:00:19, Robert Sesek wrote: ...
4 years, 5 months ago (2016-07-08 15:09:09 UTC) #8
Robert Sesek
lgtm
4 years, 5 months ago (2016-07-08 15:25:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134623002/40001
4 years, 5 months ago (2016-07-08 15:28:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 16:48:02 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 16:49:23 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/678557d52c9cf757fd2759067131418bb88de5e4
Cr-Commit-Position: refs/heads/master@{#404414}

Powered by Google App Engine
This is Rietveld 408576698