Fix renderer assert after autofill

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 3156 matching lines @@
         if (oldFocusedElement->isRootEditableElement())
             frame()->editor()->didEndEditing();
 
         if (view()) {
             Widget* oldWidget = widgetForElement(oldFocusedElement.get());
             if (oldWidget)
                 oldWidget->setFocus(false);
             else
                 view()->setFocus(false);
         }
+
+        // Autofill client may have modified the value of newFocusNode, thus require

[falken, 2013/07/31 18:27:01]

nit: newFocusNode -> newFocusedNode

+        // a layout update here, otherwise it will assert at newFocusedNode->isFocusable().
+        // See crbug.com/251163.
+        RenderObject* renderer = newFocusedNode ? newFocusedNode->renderer() : 0;

[tkent, 2013/07/31 21:52:05]

It looks this code is not compilable.  There is no newFocusedNode variable in
this function.

+        if (renderer && renderer->needsLayout())
+            updateLayout();

[esprehn, 2013/07/31 22:20:25]

You shouldn't reach into the render tree and inspect layout state like this, and
manually calling updateLayout is definitely bad.

Perhaps you want to call updateLayoutIgnorePendingStylesheets() ? I see some
callers of setFocusedElement already do that.

Even then this looks scary, now every time we change the focused node you
trigger a style recalc and layout which is bad.

     }
 
     if (newFocusedElement && newFocusedElement->isFocusable()) {
         if (newFocusedElement->isRootEditableElement() && !acceptsEditingFocus(newFocusedElement.get())) {
             // delegate blocks focus change
             focusChangeBlocked = true;
             goto SetFocusedElementDone;
         }
         // Set focus on the new node
         m_focusedElement = newFocusedElement;
@@ skipping 1892 matching lines @@
 {
     return DocumentLifecycleNotifier::create(this);
 }
 
 DocumentLifecycleNotifier* Document::lifecycleNotifier()
 {
     return static_cast<DocumentLifecycleNotifier*>(ScriptExecutionContext::lifecycleNotifier());
 }
 
 } // namespace WebCore