[wasm] cloning compiled module before instantiation

src/wasm/wasm-module.h

Index: src/wasm/wasm-module.h
diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h
index 4e573ab4eba65996a5b77bf3d6990558ac5cacad..6aca8d625d0b51b37e381a382bdee89703fa5125 100644
--- a/src/wasm/wasm-module.h
+++ b/src/wasm/wasm-module.h
@@ -165,6 +165,9 @@ struct WasmModule {
   uint32_t max_mem_pages;     // maximum size of the memory in 64k pages.
   bool mem_export;            // true if the memory is exported.
   bool mem_external;          // true if the memory is external.
+  // TODO(wasm): model the start_function_index as a uint32_t, to be able
+  // to represent any valid index in the wasm function table. Model its
+  // presence/absence separately, as a bool.

[titzer, 2016/07/12 15:45:52]

Can you remove this TODO? I'd rather keep the current behavior. We'll need to
establish a limit on the number of functions in the decoder and the range of an
int seems reasonable to me.

[Mircea Trofin, 2016/07/12 16:12:23]

Reworded it, we do have a problem, so I'd be remiss if I just removed it. 

   int start_function_index;   // start function, if any.
   ModuleOrigin origin;        // origin of the module
 
@@ -359,6 +362,11 @@ Handle<WasmDebugInfo> GetDebugInfo(Handle<JSObject> wasm);
 // Return the number of functions in the given wasm object.
 int GetNumberOfFunctions(JSObject* wasm);
 
+// Create an export JSFunction

[titzer, 2016/07/12 15:45:52]

s/an/and/

[Mircea Trofin, 2016/07/12 16:12:23]

Done.

+Handle<JSFunction> CreateExport(Isolate* isolate, Handle<Code> export_code,
+                                Handle<String> name, int arity,
+                                Handle<JSObject> module_instance);
+
 // Check whether the given object is a wasm object.
 // This checks the number and type of internal fields, so it's not 100 percent
 // secure. If it turns out that we need more complete checks, we could add a