Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2134543003: Reland of Clear the login webview when SAML flow is canceled (original CL crrev.com/1988113004). (Closed)

Created:
4 years, 5 months ago by emaxx
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Reland of Clear the login webview when SAML flow is canceled (original CL crrev.com/1988113004). The original CL was later reverted (CL crrev.com/2068953003) due to frequent failures of the SAMLPolicyTest.SAMLInterstitialNext test. This follow-up CL should resolve the tests flakiness. The problem with the original CL was that it could introduce raising the "ready" event too early, so that the test code could start working when the webview was still pointing to the blank page. BUG=613245, 620353 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2082533002 Cr-Commit-Position: refs/heads/master@{#400703} (cherry picked from commit 93dc10b6eaaf3be6c4634a2e91e671da21338424) Committed: https://chromium.googlesource.com/chromium/src/+/4aa965d679259cc8545572fd4a34688671920711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 6 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
emaxx
4 years, 5 months ago (2016-07-08 01:18:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4aa965d679259cc8545572fd4a34688671920711.

Powered by Google App Engine
This is Rietveld 408576698