Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 2134523002: [Android] Revise SIGTERM and unknown test result handling. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Revise SIGTERM and unknown test result handling. Currently, the test runner only takes action on SIGTERM on test execution threads and only stops at the end of a test shard. In some cases, this isn't fast enough. This CL makes the main thread drop test execution. This CL also tweaks the handling of test results to better handle UNKNOWNs. BUG= Committed: https://crrev.com/6c04fde85a18fc3bc8498f9735b984beaf8209c7 Cr-Commit-Position: refs/heads/master@{#404507}

Patch Set 1 #

Patch Set 2 : Always catch TestTerminated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -30 lines) Patch
M build/android/pylib/base/base_test_result.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 1 1 chunk +46 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
4 years, 5 months ago (2016-07-08 00:26:55 UTC) #2
rnephew (Reviews Here)
On 2016/07/08 00:26:55, jbudorick wrote: lgtm
4 years, 5 months ago (2016-07-08 21:07:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134523002/20001
4 years, 5 months ago (2016-07-08 21:09:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 22:16:08 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 22:16:14 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 22:17:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c04fde85a18fc3bc8498f9735b984beaf8209c7
Cr-Commit-Position: refs/heads/master@{#404507}

Powered by Google App Engine
This is Rietveld 408576698