Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2134513002: Enable basic printing on ChromeOS (Closed)

Created:
4 years, 5 months ago by skau
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable basic printing on ChromeOS Rudimentary print support is being implemented for Chrome OS using CUPS. This enables native printing on Chrome OS. If CUPS is not enabled, no differences are noticable. BUG=607668 R=briannorris@chromium.org Committed: https://crrev.com/687d7248d07c24b9c6a5da4e9ee5c4dd939f16e9 Cr-Commit-Position: refs/heads/master@{#404913}

Patch Set 1 #

Patch Set 2 : fix unit tests #

Patch Set 3 : Too agressive the first time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
skau
4 years, 5 months ago (2016-07-08 00:21:35 UTC) #1
skau
I would like to enable basic printing for Chrome OS as I have a functioning ...
4 years, 5 months ago (2016-07-08 00:56:13 UTC) #3
skau
Could you look at this when you get a chance?
4 years, 5 months ago (2016-07-12 18:39:38 UTC) #5
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-12 19:06:36 UTC) #6
Lei Zhang
Never got an email for this CL until today. Did you forget to add reviewers ...
4 years, 5 months ago (2016-07-12 19:22:03 UTC) #7
skau
On 2016/07/12 19:22:03, Lei Zhang wrote: > Never got an email for this CL until ...
4 years, 5 months ago (2016-07-12 19:52:25 UTC) #8
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-12 20:10:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134513002/40001
4 years, 5 months ago (2016-07-12 20:12:41 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191601) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 21:07:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134513002/40001
4 years, 5 months ago (2016-07-12 22:01:20 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 02:28:18 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 02:29:24 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:29:58 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/687d7248d07c24b9c6a5da4e9ee5c4dd939f16e9
Cr-Commit-Position: refs/heads/master@{#404913}

Powered by Google App Engine
This is Rietveld 408576698