Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2134443002: [turbofan] Fixed segmentation fault while printing TurboFan node (Closed)

Created:
4 years, 5 months ago by Deon
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fixed segmentation fault while printing TurboFan node Graph trimmer can set Input as null and subsequent printing call could cause segmentation fault. R=bmeurer@chromium.org, jarin@chromium.org Committed: https://crrev.com/1d26ed290b3b30e9582b5857561a6948f02d376b Cr-Commit-Position: refs/heads/master@{#37658}

Patch Set 1 #

Patch Set 2 : Fixed segmentation fault while printing TurboFan node #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Deon
This is follow-up from https://codereview.chromium.org/1992653003/. Separate two changes as suggested by Benedikt.
4 years, 5 months ago (2016-07-07 21:23:27 UTC) #1
Benedikt Meurer
Awesome, thanks for fixing. LGTM. You might need to add yourself to AUTHORS (wtih the ...
4 years, 5 months ago (2016-07-09 18:01:48 UTC) #3
Deon
Thank you, Benedikt! I have updated AUTHORS with my account registered at Google Individual CLA.
4 years, 5 months ago (2016-07-11 20:13:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134443002/20001
4 years, 5 months ago (2016-07-11 20:38:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 20:41:15 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 20:43:08 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d26ed290b3b30e9582b5857561a6948f02d376b
Cr-Commit-Position: refs/heads/master@{#37658}

Powered by Google App Engine
This is Rietveld 408576698