V8. ASM-2-WASM. Migrates asm-wasm-builder to the new asm-typer.

V8. ASM-2-WASM. Migrates asm-wasm-builder to the new asm-typer.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=mjsunit/wasm/*
LOG=N

Committed: https://crrev.com/aa91225289beaaf0c6f47bf2031250019db327bf
Cr-Commit-Position: refs/heads/master@{#37729}

[John, 2016-07-13 14:37:16]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 14:37:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-07-13 14:37:32]

The CQ bit was unchecked by jpp@chromium.org

[John, 2016-07-13 14:37:44]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 14:37:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 14:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 14:43:55]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[John, 2016-07-13 14:49:29]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 14:49:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-07-13 14:51:06]

Description was changed from

==========
Off of types.h

BUG=
==========

to

==========
V8. ASM-2-WASM. Migrates asm-wasm-builder to the new asm-typer.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=mjsunit/wasm/*
LOG=N
==========

[commit-bot: I haz the power, 2016-07-13 15:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 15:12:44]

Dry run: This issue passed the CQ dry run.

[John, 2016-07-13 15:16:34]

jpp@chromium.org changed reviewers:
+ bradnelson@chromium.org

[John, 2016-07-13 15:16:35]

This should be simpler than the previous one. :)

A few things that I would hope we could address in the future:

1) the error messages are heinous and almost useless;
2) It would be nice if we could ensure that every single (expression) node in
the AST has its type recorded by the typer.
3) The 'nits' I noted on the code.

[bradnelson, 2016-07-13 17:05:31]

How about landing the test changes as a separate change first?
That will show they're orthogonal fixes?

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-js.cc
File src/asmjs/asm-js.cc (right):

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-js.cc#ne...
src/asmjs/asm-js.cc:64: if (i::FLAG_enable_simd_asmjs) {
Just drop entirely.

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-types.cc
File src/asmjs/asm-types.cc (right):

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-types.cc...
src/asmjs/asm-types.cc:186: // TODO(jpp): Remove this method.
Any reason not to do it now?

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-wasm-bui...
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-wasm-bui...
src/asmjs/asm-wasm-builder.cc:1624: // TODO(jpp): log a warning and move on.
Where does this get hit?

https://codereview.chromium.org/2134333003/diff/140001/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2134333003/diff/140001/src/wasm/wasm-js.cc#ne...
src/wasm/wasm-js.cc:155: // TODO(jpp): no support.
Just drop it.

[John, 2016-07-13 18:09:10]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 18:09:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-07-13 18:13:03]

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-js.cc
File src/asmjs/asm-js.cc (right):

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-js.cc#ne...
src/asmjs/asm-js.cc:64: if (i::FLAG_enable_simd_asmjs) {
On 2016/07/13 17:05:30, bradnelson wrote:
> Just drop entirely.

Done.

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-types.cc
File src/asmjs/asm-types.cc (right):

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-types.cc...
src/asmjs/asm-types.cc:186: // TODO(jpp): Remove this method.
On 2016/07/13 17:05:30, bradnelson wrote:
> Any reason not to do it now?

To avoid having even moar changes on this CL. I already have a CL dealing with
these.

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-wasm-bui...
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2134333003/diff/140001/src/asmjs/asm-wasm-bui...
src/asmjs/asm-wasm-builder.cc:1624: // TODO(jpp): log a warning and move on.
On 2016/07/13 17:05:30, bradnelson wrote:
> Where does this get hit?

I did not investigate. I'll follow up shortly.

https://codereview.chromium.org/2134333003/diff/140001/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2134333003/diff/140001/src/wasm/wasm-js.cc#ne...
src/wasm/wasm-js.cc:155: // TODO(jpp): no support.
On 2016/07/13 17:05:30, bradnelson wrote:
> Just drop it.

Done.

[bradnelson, 2016-07-13 18:16:41]

lgtm

[commit-bot: I haz the power, 2016-07-13 18:32:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:32:56]

Dry run: This issue passed the CQ dry run.

[John, 2016-07-13 19:35:49]

The CQ bit was checked by jpp@chromium.org

[commit-bot: I haz the power, 2016-07-13 19:35:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:38:18]

Description was changed from

==========
V8. ASM-2-WASM. Migrates asm-wasm-builder to the new asm-typer.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=mjsunit/wasm/*
LOG=N
==========

to

==========
V8. ASM-2-WASM. Migrates asm-wasm-builder to the new asm-typer.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=mjsunit/wasm/*
LOG=N
==========

[commit-bot: I haz the power, 2016-07-13 19:38:20]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-13 19:40:22]

Description was changed from

==========
V8. ASM-2-WASM. Migrates asm-wasm-builder to the new asm-typer.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=mjsunit/wasm/*
LOG=N
==========

to

==========
V8. ASM-2-WASM. Migrates asm-wasm-builder to the new asm-typer.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=mjsunit/wasm/*
LOG=N

Committed: https://crrev.com/aa91225289beaaf0c6f47bf2031250019db327bf
Cr-Commit-Position: refs/heads/master@{#37729}
==========

[commit-bot: I haz the power, 2016-07-13 19:40:23]

Patchset 9 (id:??) landed as
https://crrev.com/aa91225289beaaf0c6f47bf2031250019db327bf
Cr-Commit-Position: refs/heads/master@{#37729}