Add Sparse Histogram Support to metricsPrivate

chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/metrics_private/metrics_private_api.h"
 
 #include <algorithm>
 
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
+#include "base/metrics/sparse_histogram.h"
 #include "chrome/browser/metrics/metrics_service.h"
 #include "chrome/common/extensions/api/metrics_private.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/user_metrics.h"
 #include "extensions/common/extension.h"
 
 namespace extensions {
 
 namespace GetIsCrashReportingEnabled =
     api::metrics_private::GetIsCrashReportingEnabled;
 namespace GetVariationParams = api::metrics_private::GetVariationParams;
 namespace GetFieldTrial = api::metrics_private::GetFieldTrial;
 namespace RecordUserAction = api::metrics_private::RecordUserAction;
 namespace RecordValue = api::metrics_private::RecordValue;
+namespace RecordSparseValue = api::metrics_private::RecordSparseValue;
 namespace RecordPercentage = api::metrics_private::RecordPercentage;
 namespace RecordCount = api::metrics_private::RecordCount;
 namespace RecordSmallCount = api::metrics_private::RecordSmallCount;
 namespace RecordMediumCount = api::metrics_private::RecordMediumCount;
 namespace RecordTime = api::metrics_private::RecordTime;
 namespace RecordMediumTime = api::metrics_private::RecordMediumTime;
 namespace RecordLongTime = api::metrics_private::RecordLongTime;
 
 namespace {
 
@@ skipping 85 matching lines @@
   std::string type = api::metrics_private::MetricType::ToString(
       params->metric.type);
 
   base::HistogramType histogram_type(type == "histogram-linear" ?
       base::LINEAR_HISTOGRAM : base::HISTOGRAM);
   return RecordValue(params->metric.metric_name, histogram_type,
                      params->metric.min, params->metric.max,
                      params->metric.buckets, params->value);
 }
 
+bool MetricsPrivateRecordSparseValueFunction::RunImpl() {
+  scoped_ptr<RecordSparseValue::Params> params(
+      RecordSparseValue::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+  // This particular UMA_HISTOGRAM_* is okay for runtime strings.

[Ilya Sherman, 2014/03/26 23:52:13]

nit: "runtime strings" -> "non-runtime-constant strings".

[Ilya Sherman, 2014/03/26 23:52:13]

nit: "UMA_HISTOGRAM_*" -> "UMA_HISTOGRAM_ macro"

[robliao, 2014/03/27 00:02:44]

Done.

+  UMA_HISTOGRAM_SPARSE_SLOWLY(params->metric_name, params->value);
+  return true;
+}
+
 bool MetricsPrivateRecordPercentageFunction::RunImpl() {
   scoped_ptr<RecordPercentage::Params> params(
       RecordPercentage::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
   return RecordValue(params->metric_name, base::LINEAR_HISTOGRAM,
                      1, 101, 102, params->value);
 }
 
 bool MetricsPrivateRecordCountFunction::RunImpl() {
   scoped_ptr<RecordCount::Params> params(RecordCount::Params::Create(*args_));
@@ skipping 38 matching lines @@
 bool MetricsPrivateRecordLongTimeFunction::RunImpl() {
   scoped_ptr<RecordLongTime::Params> params(
       RecordLongTime::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
   static const int kOneHourMs = 60 * 60 * 1000;
   return RecordValue(params->metric_name, base::HISTOGRAM,
                      1, kOneHourMs, 50, params->value);
 }
 
 } // namespace extensions