third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h - Issue 2134323002: Remove threading primitives from ParseHTMLOnMainThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h

Issue 2134323002: Remove threading primitives from ParseHTMLOnMainThread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove crossThreadBind from BackgroundHTMLParser Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp » ('j') | third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h

diff --git a/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h b/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h

index 85564bb1daa4b99609421fe851e58a9dab58cc1b..b7b73064d1eef5354fd9b8bab5f462a18de50db6 100644

--- a/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h

+++ b/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h

@@ -98,7 +98,8 @@ private:

void sendTokensToMainThread();

void updateDocument(const String& decodedData);

- void runOnMainThread(std::unique_ptr<CrossThreadClosure>);

+ template <typename FunctionType, typename... Ps>

+ void runOnMainThread(FunctionType, Ps&&...);

WeakPtrFactory<BackgroundHTMLParser> m_weakFactory;

BackgroundHTMLInputStream m_input;