Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: chrome/browser/chromeos/arc/arc_navigation_throttle.h

Issue 2134293002: Adding a ScrollView for IntentPickerBubbleView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding a DCHECK to make code easier to follow. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/intent_picker_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_navigation_throttle.h
diff --git a/chrome/browser/chromeos/arc/arc_navigation_throttle.h b/chrome/browser/chromeos/arc/arc_navigation_throttle.h
index 781817039ee42e2f5926586b747e7a8ed34d0c3e..0690af2a6a8951b2f5219f952ffef5cc7425dc5b 100644
--- a/chrome/browser/chromeos/arc/arc_navigation_throttle.h
+++ b/chrome/browser/chromeos/arc/arc_navigation_throttle.h
@@ -23,10 +23,6 @@ class NavigationHandle;
namespace arc {
-// Restricts the amount of apps displayed to the user without the need of a
-// ScrollView.
-constexpr size_t kMaxAppResults = 3;
-
// A class that allow us to retrieve ARC app's information and handle URL
// traffic initiated on Chrome browser, either on Chrome or an ARC's app.
class ArcNavigationThrottle : public content::NavigationThrottle {
@@ -43,6 +39,10 @@ class ArcNavigationThrottle : public content::NavigationThrottle {
SIZE,
};
+ // Restricts the amount of apps displayed to the user without the need of a
+ // ScrollView.
+ enum { kMaxAppResults = 3 };
+
using NameAndIcon = std::pair<std::string, gfx::Image>;
using ShowDisambigDialogCallback =
base::Callback<void(content::NavigationHandle* handle,
« no previous file with comments | « no previous file | chrome/browser/ui/views/intent_picker_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698