Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: chrome/browser/ui/views/intent_picker_bubble_view.h

Issue 2134293002: Adding a ScrollView for IntentPickerBubbleView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving from friend to ForTesting() methods Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/intent_picker_bubble_view.h
diff --git a/chrome/browser/ui/views/intent_picker_bubble_view.h b/chrome/browser/ui/views/intent_picker_bubble_view.h
index ae516f2db1caeb38cbbdf44a6de3a17e6637f78f..3e785d0353bc0e1e98891b61fcddf2373c99874c 100644
--- a/chrome/browser/ui/views/intent_picker_bubble_view.h
+++ b/chrome/browser/ui/views/intent_picker_bubble_view.h
@@ -21,7 +21,6 @@ class NavigationHandle;
} // namespace content
namespace views {
-class EventMonitor;
class Label;
class LabelButton;
class View;
@@ -63,6 +62,12 @@ class IntentPickerBubbleView : public views::BubbleDialogDelegateView,
static void ShowBubble(content::NavigationHandle* handle,
const std::vector<NameAndIcon>& app_info,
const ThrottleCallback& throttle_cb);
+ static std::unique_ptr<IntentPickerBubbleView> CreateBubbleForTesting(
+ const std::vector<NameAndIcon>& app_info,
+ const ThrottleCallback& throttle_cb,
+ content::WebContents* web_contents);
+ size_t GetNumberOfAppLabelsForTesting();
Yusuke Sato 2016/07/20 21:58:57 * optional: feel free to rename this to a shorter
djacobo_ 2016/07/21 16:04:11 Done.
+ ~IntentPickerBubbleView() override;
Yusuke Sato 2016/07/20 21:58:57 move to line 61?
djacobo_ 2016/07/21 16:04:11 Done.
protected:
// views::BubbleDialogDelegateView overrides:
@@ -72,7 +77,6 @@ class IntentPickerBubbleView : public views::BubbleDialogDelegateView,
IntentPickerBubbleView(const std::vector<NameAndIcon>& app_info,
ThrottleCallback throttle_cb,
content::WebContents* web_contents);
- ~IntentPickerBubbleView() override;
// views::BubbleDialogDelegateView overrides:
void OnWidgetDestroying(views::Widget* widget) override;

Powered by Google App Engine
This is Rietveld 408576698