Issue 2134283002: When validating cache consistency, skip sources in content cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2134283002: When validating cache consistency, skip sources in content cache. (Closed)

Created:
4 years, 5 months ago by scheglov

Modified:
4 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

When validating cache consistency, skip sources in content cache. Actually we need to skip it when we are about to compare modification times, not when we are going to compute them. There was the race condition in a performance benchmark. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c9c018a91f858e8b59c92b6a88b2f778f040eb2d

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -28 lines)			Patch
	M	pkg/analyzer/lib/src/context/context.dart	View		2 chunks	+22 lines, -19 lines	0 comments	Download
	M	pkg/analyzer/test/src/context/context_test.dart	View		2 chunks	+8 lines, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 5 months ago (2016-07-11 18:39:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c9c018a91f858e8b59c92b6a88b2f778f040eb2d (presubmit successful).