Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2134273002: Fix inspector overlay when use-zoom-for-dsf is enabled. (Closed)

Created:
4 years, 5 months ago by Bret
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix inspector overlay when use-zoom-for-dsf is enabled. Inspector overlays were misaligned because the path points were drawing in window coordinates and needed to be scaled to viewport coordinates. Should be no change when use-zoom-for-dsf is off. BUG=622862 Committed: https://crrev.com/6651b97ebd509e97bea8929303738dc20a3ed880 Review-Url: https://codereview.chromium.org/2108803006 Cr-Original-Commit-Position: refs/heads/master@{#404063} Cr-Commit-Position: refs/heads/master@{#404285} (cherry picked from commit fca01d88e345fce580cd8acc7245f6cdc89a0c84) Committed: https://chromium.googlesource.com/chromium/src/+/832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M content/renderer/devtools/devtools_agent.cc View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp View 8 chunks +18 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Bret
4 years, 5 months ago (2016-07-11 18:33:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb.

Powered by Google App Engine
This is Rietveld 408576698