DevTools: Migrate General tab settings to extensions

Source/devtools/front_end/modules.js

Index: Source/devtools/front_end/modules.js
diff --git a/Source/devtools/front_end/modules.js b/Source/devtools/front_end/modules.js
index 0e2f024990c5aeeef42601316ca2908558cb2c9a..475352b1e036cd60db69aeda45fd2faaa6001989 100644
--- a/Source/devtools/front_end/modules.js
+++ b/Source/devtools/front_end/modules.js
@@ -78,6 +78,28 @@ var allDescriptors = [
                     }
                 ],
                 className: "WebInspector.Main.DebugReloadActionDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",

[pfeldman, 2014/03/27 15:27:14]

type: "settings",
title: "...",
setting: "cacheDisabled",
settingType: "checkbox"

[apavlov, 2014/03/28 10:21:23]

Done.

+                title: "Disable cache (while DevTools is open)",
+                settingName: "cacheDisabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Appearance",

[pfeldman, 2014/03/27 15:27:14]

section

[apavlov, 2014/03/28 10:21:23]

Done.

+                title: "Split panels vertically when docked to %s",
+                settingName: "splitVerticallyWhenDockedToRight",
+                settingType: "checkbox",
+                className: "WebInspector.Main.SplitVerticallySettingDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Appearance",
+                title: "Enable %s + 1-9 shortcut to switch panels",

[pfeldman, 2014/03/27 15:27:14]

I wonder if we should do platform-specific settings instead.

[apavlov, 2014/03/28 10:21:23]

Resorted to a custom setting element instead

+                settingName: "shortcutPanelSwitch",
+                settingType: "checkbox",
+                className: "WebInspector.Main.ShortcutPanelSwitchSettingDelegate"
             }
         ]
     },
@@ -119,6 +141,42 @@ var allDescriptors = [
                 type: "@WebInspector.Revealer",
                 contextTypes: ["WebInspector.DOMNode"],
                 className: "WebInspector.ElementsPanel.DOMNodeRevealer"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Color format",
+                settingName: "colorFormat",
+                settingType: "select",
+                className: "WebInspector.StylesSidebarPane.ColorFormatSettingDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Show user agent styles",
+                settingName: "showUserAgentStyles",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Show user agent shadow DOM",
+                settingName: "showUAShadowDOM",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Word wrap",
+                settingName: "domWordWrap",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Show rulers",
+                settingName: "showMetricsRulers",
+                settingType: "checkbox"
             }
         ],
         scripts: [ "ElementsPanel.js" ]
@@ -157,6 +215,14 @@ var allDescriptors = [
               type: "@WebInspector.TokenizerFactory",
               className: "WebInspector.CodeMirrorUtils.TokenizerFactory"
             },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Default indentation",
+                settingName: "textEditorIndent",
+                settingType: "select",
+                className: "WebInspector.CodeMirrorTextEditor.EditorIndentSettingDelegate"
+            }
         ],
         scripts: [ "CodeMirrorTextEditor.js" ]
     },
@@ -237,6 +303,89 @@ var allDescriptors = [
                     }
                 ],
                 className: "WebInspector.SourcesPanel.ShowGoToSourceDialogActionDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                title: "Disable JavaScript",
+                settingName: "javaScriptDisabled",
+                settingType: "checkbox",
+                configurable: true,
+                className: "WebInspector.SourcesPanel.DisableJavaScriptSettingDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Search in content scripts",
+                settingName: "searchInContentScripts",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Enable JavaScript source maps",
+                settingName: "jsSourceMapsEnabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Detect indentation",
+                settingName: "textEditorAutoDetectIndent",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Autocompletion",
+                settingName: "textEditorAutocompletion",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Bracket matching",
+                settingName: "textEditorBracketMatching",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Show whitespace characters",
+                settingName: "showWhitespacesInEditor",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Enable CSS source maps",
+                settingName: "cssSourceMapsEnabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                title: "Auto-reload generated CSS",
+                parentSettingName: "cssSourceMapsEnabled",
+                settingName: "cssReloadEnabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                experiment: "frameworksDebuggingSupport",
+                title: "Skip stepping through sources with particular names",
+                settingName: "skipStackFramesSwitch",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                experiment: "frameworksDebuggingSupport",
+                title: "Pattern",
+                settingName: "skipStackFramesPattern",
+                parentSettingName: "skipStackFramesSwitch",
+                settingType: "input",
+                maxLength: 1000,
+                width: "100px",
+                className: "WebInspector.SourcesPanel.SkipStackFramePatternSettingDelegate"
             }
         ],
         scripts: [ "SourcesPanel.js" ]
@@ -268,6 +417,20 @@ var allDescriptors = [
                 type: "@WebInspector.ContextMenu.Provider",
                 contextTypes: ["WebInspector.RemoteObject"],
                 className: "WebInspector.ProfilesPanel.ContextMenuProvider"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Profiler",
+                title: "Show advanced heap snapshot properties",
+                settingName: "showAdvancedHeapSnapshotProperties",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Profiler",
+                title: "High resolution CPU profiling",
+                settingName: "highResolutionCpuProfiling",
+                settingType: "checkbox"
             }
         ],
         scripts: [ "ProfilesPanel.js" ]
@@ -333,6 +496,27 @@ var allDescriptors = [
                     }
                 ],
                 className: "WebInspector.ConsoleView.ShowConsoleActionDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Console",
+                title: "Log XMLHttpRequests",
+                settingName: "monitoringXHREnabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Console",
+                title: "Preserve log upon navigation",
+                settingName: "preserveConsoleLog",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Console",
+                title: "Show timestamps",
+                settingName: "consoleTimestampsEnabled",
+                settingType: "checkbox"
             }
         ],
         scripts: [ "ConsolePanel.js" ]