DevTools: Migrate General tab settings to extensions

Source/devtools/front_end/modules.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 60 matching lines @@
                 className: "WebInspector.InspectorView.DrawerToggleActionDelegate"
             },
             {
                 type: "@WebInspector.ActionDelegate",
                 bindings: [
                     {
                         shortcut: "Alt+R"
                     }
                 ],
                 className: "WebInspector.Main.DebugReloadActionDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",

[pfeldman, 2014/03/27 15:27:14]

type: "settings",
title: "...",
setting: "cacheDisabled",
settingType: "checkbox"

[apavlov, 2014/03/28 10:21:23]

Done.

+                title: "Disable cache (while DevTools is open)",
+                settingName: "cacheDisabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Appearance",

[pfeldman, 2014/03/27 15:27:14]

section

[apavlov, 2014/03/28 10:21:23]

Done.

+                title: "Split panels vertically when docked to %s",
+                settingName: "splitVerticallyWhenDockedToRight",
+                settingType: "checkbox",
+                className: "WebInspector.Main.SplitVerticallySettingDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Appearance",
+                title: "Enable %s + 1-9 shortcut to switch panels",

[pfeldman, 2014/03/27 15:27:14]

I wonder if we should do platform-specific settings instead.

[apavlov, 2014/03/28 10:21:23]

Resorted to a custom setting element instead

+                settingName: "shortcutPanelSwitch",
+                settingType: "checkbox",
+                className: "WebInspector.Main.ShortcutPanelSwitchSettingDelegate"
             }
         ]
     },
     {
         name: "elements",
         extensions: [
             {
                 type: "@WebInspector.Panel",
                 name: "elements",
                 title: "Elements",
@@ skipping 21 matching lines @@
             },
             {
                 type: "@WebInspector.Renderer",
                 contextTypes: ["WebInspector.DOMNode"],
                 className: "WebInspector.ElementsTreeOutline.Renderer"
             },
             {
                 type: "@WebInspector.Revealer",
                 contextTypes: ["WebInspector.DOMNode"],
                 className: "WebInspector.ElementsPanel.DOMNodeRevealer"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Color format",
+                settingName: "colorFormat",
+                settingType: "select",
+                className: "WebInspector.StylesSidebarPane.ColorFormatSettingDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Show user agent styles",
+                settingName: "showUserAgentStyles",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Show user agent shadow DOM",
+                settingName: "showUAShadowDOM",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Word wrap",
+                settingName: "domWordWrap",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Elements",
+                title: "Show rulers",
+                settingName: "showMetricsRulers",
+                settingType: "checkbox"
             }
         ],
         scripts: [ "ElementsPanel.js" ]
     },
     {
         name: "network",
         extensions: [
             {
                 type: "@WebInspector.Panel",
                 name: "network",
@@ skipping 18 matching lines @@
         name: "codemirror",
         extensions: [
             {
                 type: "@WebInspector.InplaceEditor",
                 className: "WebInspector.CodeMirrorUtils"
             },
             {
               type: "@WebInspector.TokenizerFactory",
               className: "WebInspector.CodeMirrorUtils.TokenizerFactory"
             },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Default indentation",
+                settingName: "textEditorIndent",
+                settingType: "select",
+                className: "WebInspector.CodeMirrorTextEditor.EditorIndentSettingDelegate"
+            }
         ],
         scripts: [ "CodeMirrorTextEditor.js" ]
     },
     {
         name: "sources",
         extensions: [
             {
                 type: "@WebInspector.Panel",
                 name: "sources",
                 title: "Sources",
@@ skipping 60 matching lines @@
                     {
                         platform: "mac",
                         shortcut: "Meta+O Meta+P"
                     },
                     {
                         platform: "win,linux",
                         shortcut: "Ctrl+O Ctrl+P"
                     }
                 ],
                 className: "WebInspector.SourcesPanel.ShowGoToSourceDialogActionDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                title: "Disable JavaScript",
+                settingName: "javaScriptDisabled",
+                settingType: "checkbox",
+                configurable: true,
+                className: "WebInspector.SourcesPanel.DisableJavaScriptSettingDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Search in content scripts",
+                settingName: "searchInContentScripts",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Enable JavaScript source maps",
+                settingName: "jsSourceMapsEnabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Detect indentation",
+                settingName: "textEditorAutoDetectIndent",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Autocompletion",
+                settingName: "textEditorAutocompletion",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Bracket matching",
+                settingName: "textEditorBracketMatching",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Show whitespace characters",
+                settingName: "showWhitespacesInEditor",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                title: "Enable CSS source maps",
+                settingName: "cssSourceMapsEnabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                title: "Auto-reload generated CSS",
+                parentSettingName: "cssSourceMapsEnabled",
+                settingName: "cssReloadEnabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Sources",
+                experiment: "frameworksDebuggingSupport",
+                title: "Skip stepping through sources with particular names",
+                settingName: "skipStackFramesSwitch",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                experiment: "frameworksDebuggingSupport",
+                title: "Pattern",
+                settingName: "skipStackFramesPattern",
+                parentSettingName: "skipStackFramesSwitch",
+                settingType: "input",
+                maxLength: 1000,
+                width: "100px",
+                className: "WebInspector.SourcesPanel.SkipStackFramePatternSettingDelegate"
             }
         ],
         scripts: [ "SourcesPanel.js" ]
     },
     {
         name: "timeline",
         extensions: [
             {
                 type: "@WebInspector.Panel",
                 name: "timeline",
@@ skipping 11 matching lines @@
                 type: "@WebInspector.Panel",
                 name: "profiles",
                 title: "Profiles",
                 order: 4,
                 className: "WebInspector.ProfilesPanel"
             },
             {
                 type: "@WebInspector.ContextMenu.Provider",
                 contextTypes: ["WebInspector.RemoteObject"],
                 className: "WebInspector.ProfilesPanel.ContextMenuProvider"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Profiler",
+                title: "Show advanced heap snapshot properties",
+                settingName: "showAdvancedHeapSnapshotProperties",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Profiler",
+                title: "High resolution CPU profiling",
+                settingName: "highResolutionCpuProfiling",
+                settingType: "checkbox"
             }
         ],
         scripts: [ "ProfilesPanel.js" ]
     },
     {
         name: "resources",
         extensions: [
             {
                 type: "@WebInspector.Panel",
                 name: "resources",
@@ skipping 45 matching lines @@
                 className: "WebInspector.ConsolePanel.ConsoleRevealer"
             },
             {
                 type: "@WebInspector.ActionDelegate",
                 bindings: [
                     {
                         shortcut: "Ctrl+`"
                     }
                 ],
                 className: "WebInspector.ConsoleView.ShowConsoleActionDelegate"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Console",
+                title: "Log XMLHttpRequests",
+                settingName: "monitoringXHREnabled",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Console",
+                title: "Preserve log upon navigation",
+                settingName: "preserveConsoleLog",
+                settingType: "checkbox"
+            },
+            {
+                type: "@WebInspector.UISettingDelegate",
+                sectionName: "Console",
+                title: "Show timestamps",
+                settingName: "consoleTimestampsEnabled",
+                settingType: "checkbox"
             }
         ],
         scripts: [ "ConsolePanel.js" ]
     },
     {
         name: "settings",
         extensions: [
             {
                 type: "@WebInspector.ActionDelegate",
                 bindings: [
@@ skipping 37 matching lines @@
         name: "handler-registry",
         extensions: [
             {
                 type: "@WebInspector.ContextMenu.Provider",
                 contextTypes: ["WebInspector.UISourceCode", "WebInspector.Resource", "WebInspector.NetworkRequest", "Node"],
                 className: "WebInspector.HandlerRegistry.ContextMenuProvider"
             }
         ]
     }
 ];