DevTools: Migrate General tab settings to extensions

Source/devtools/front_end/SettingsUI.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 77 matching lines @@
     var fieldset = document.createElement("fieldset");
     fieldset.disabled = !setting.get();
     setting.addChangeListener(settingChanged);
     return fieldset;
 
     function settingChanged()
     {
         fieldset.disabled = !setting.get();
     }
 }
+
+/**
+ * @param {string} text
+ * @return {?string}
+ */
+WebInspector.SettingsUI.regexValidator = function(text)
+{
+    var regex;
+    try {
+        regex = new RegExp(text);
+    } catch (e) {
+    }
+    return regex ? null : WebInspector.UIString("Invalid pattern");
+}
+
+/**
+ * @constructor
+ */
+WebInspector.UISettingDelegate = function()
+{
+}
+
+WebInspector.UISettingDelegate.prototype = {

[pfeldman, 2014/03/27 15:27:14]

Let users return elements instead.

[apavlov, 2014/03/28 10:21:23]

Done.

+    /**
+     * @param {!WebInspector.Event} event
+     */
+    settingChanged: function(event)
+    {
+    },
+
+    /**
+     * @return {!Array.<*>|undefined}
+     */
+    titleTemplateArguments: function()
+    {
+        return undefined;
+    }
+}
+
+/**
+ * @constructor
+ * @extends {WebInspector.UISettingDelegate}
+ */
+WebInspector.SelectUISettingDelegate = function()

[pfeldman, 2014/03/27 15:27:14]

Lets either use elements or derive from descriptor.

[apavlov, 2014/03/28 10:21:23]

Done.

+{
+    WebInspector.UISettingDelegate.call(this);
+}
+
+WebInspector.SelectUISettingDelegate.prototype = {
+    /**
+     * @return {!Array.<!Array.<*>>}
+     */
+    settingOptions: function()
+    {
+        throw "Not implemented";
+    },
+
+    __proto__: WebInspector.UISettingDelegate.prototype
+}
+
+/**
+ * @constructor
+ * @extends {WebInspector.UISettingDelegate}
+ */
+WebInspector.InputUISettingDelegate = function()

[pfeldman, 2014/03/27 15:27:14]

Ditto

[apavlov, 2014/03/28 10:21:23]

Done.

+{
+    WebInspector.UISettingDelegate.call(this);
+}
+
+WebInspector.InputUISettingDelegate.prototype = {
+    /**
+     * @param {string} value
+     * @return {?string}
+     */
+    validateInput: function(value)
+    {
+        return null;
+    },
+
+    __proto__: WebInspector.UISettingDelegate.prototype
+}
+
+/**
+ * @interface
+ */
+WebInspector.ConfigurableUISettingDelegate = function()
+{
+}
+
+WebInspector.ConfigurableUISettingDelegate.prototype = {
+    /**
+     * @param {!Element} settingElement
+     * @param {!Element} containerElement
+     */
+    configure: function(settingElement, containerElement) {}
+}