DevTools: Migrate General tab settings to extensions

Source/devtools/front_end/Main.js

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 718 matching lines @@
     /**
      * @return {boolean}
      */
     handleAction: function()
     {
         WebInspector.reload();
         return true;
     }
 }
 
+/**
+ * @constructor
+ * @extends {WebInspector.UISettingDelegate}
+ */
+WebInspector.Main.SplitVerticallySettingDelegate = function()
+{
+    WebInspector.UISettingDelegate.call(this);
+}
+
+WebInspector.Main.SplitVerticallySettingDelegate.prototype = {
+    /**
+     * @return {!Array.<string>}
+     */
+    titleTemplateArguments: function()
+    {
+        return [WebInspector.experimentsSettings.dockToLeft.isEnabled() ? "left or right" : "right"];

[pfeldman, 2014/03/27 15:27:14]

Dock to left is to be removed. Feel free to restore setting to "right"

[apavlov, 2014/03/28 10:21:23]

Done.

+    },
+
+    __proto__: WebInspector.UISettingDelegate.prototype
+}
+
+/**
+ * @constructor
+ * @extends {WebInspector.UISettingDelegate}
+ */
+WebInspector.Main.ShortcutPanelSwitchSettingDelegate = function()
+{
+    WebInspector.UISettingDelegate.call(this);
+}
+
+WebInspector.Main.ShortcutPanelSwitchSettingDelegate.prototype = {
+    /**
+     * @return {!Array.<string>}
+     */
+    titleTemplateArguments: function()

[pfeldman, 2014/03/27 15:27:14]

This is too complex. You should provide entire elements as a fallback.

[apavlov, 2014/03/28 10:21:23]

Done.

+    {
+        return [WebInspector.isMac() ? "Cmd" : "Ctrl"];
+    },
+
+    __proto__: WebInspector.UISettingDelegate.prototype
+}
+
 new WebInspector.Main();
 
 window.DEBUG = true;
 
 // These methods are added for backwards compatibility with Devtools CodeSchool extension.
 // DO NOT REMOVE
 
 WebInspector.__defineGetter__("inspectedPageURL", function()
 {
     return WebInspector.resourceTreeModel.inspectedPageURL();
 });
 
 WebInspector.panel = function(name)
 {
     return WebInspector.inspectorView.panel(name);
 }