Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Side by Side Diff: Source/devtools/front_end/DebuggerModel.js

Issue 213423010: DevTools: Migrate General tab settings to extensions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comments addressed Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/devtools/front_end/HandlerRegistry.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 this._breakpointsActive = true; 49 this._breakpointsActive = true;
50 50
51 WebInspector.settings.pauseOnExceptionEnabled.addChangeListener(this._pauseO nExceptionStateChanged, this); 51 WebInspector.settings.pauseOnExceptionEnabled.addChangeListener(this._pauseO nExceptionStateChanged, this);
52 WebInspector.settings.pauseOnCaughtException.addChangeListener(this._pauseOn ExceptionStateChanged, this); 52 WebInspector.settings.pauseOnCaughtException.addChangeListener(this._pauseOn ExceptionStateChanged, this);
53 53
54 WebInspector.settings.enableAsyncStackTraces.addChangeListener(this._asyncSt ackTracesStateChanged, this); 54 WebInspector.settings.enableAsyncStackTraces.addChangeListener(this._asyncSt ackTracesStateChanged, this);
55 55
56 this.enableDebugger(); 56 this.enableDebugger();
57 57
58 this.applySkipStackFrameSettings(); 58 WebInspector.settings.skipStackFramesSwitch.addChangeListener(this._applySki pStackFrameSettings, this);
59 WebInspector.settings.skipStackFramesPattern.addChangeListener(this._applySk ipStackFrameSettings, this);
60 this._applySkipStackFrameSettings();
59 } 61 }
60 62
61 /** 63 /**
62 * Keep these in sync with WebCore::ScriptDebugServer 64 * Keep these in sync with WebCore::ScriptDebugServer
63 * 65 *
64 * @enum {string} 66 * @enum {string}
65 */ 67 */
66 WebInspector.DebuggerModel.PauseOnExceptionsState = { 68 WebInspector.DebuggerModel.PauseOnExceptionsState = {
67 DontPauseOnExceptions : "none", 69 DontPauseOnExceptions : "none",
68 PauseOnAllExceptions : "all", 70 PauseOnAllExceptions : "all",
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 */ 684 */
683 callStackModified: function(newCallFrames, details, asyncStackTrace) 685 callStackModified: function(newCallFrames, details, asyncStackTrace)
684 { 686 {
685 // FIXME: declare this property in protocol and in JavaScript. 687 // FIXME: declare this property in protocol and in JavaScript.
686 if (details && details["stack_update_needs_step_in"]) 688 if (details && details["stack_update_needs_step_in"])
687 this.stepInto(); 689 this.stepInto();
688 else if (newCallFrames && newCallFrames.length) 690 else if (newCallFrames && newCallFrames.length)
689 this._pausedScript(newCallFrames, this._debuggerPausedDetails.reason , this._debuggerPausedDetails.auxData, this._debuggerPausedDetails.breakpointIds , asyncStackTrace); 691 this._pausedScript(newCallFrames, this._debuggerPausedDetails.reason , this._debuggerPausedDetails.auxData, this._debuggerPausedDetails.breakpointIds , asyncStackTrace);
690 }, 692 },
691 693
692 applySkipStackFrameSettings: function() 694 _applySkipStackFrameSettings: function()
693 { 695 {
694 if (!WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabl ed()) 696 if (!WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabl ed())
695 return; 697 return;
696 var settings = WebInspector.settings; 698 var settings = WebInspector.settings;
697 var patternParameter = settings.skipStackFramesSwitch.get() ? settings.s kipStackFramesPattern.get() : undefined; 699 var patternParameter = settings.skipStackFramesSwitch.get() ? settings.s kipStackFramesPattern.get() : undefined;
698 this._agent.skipStackFrames(patternParameter); 700 this._agent.skipStackFrames(patternParameter);
699 }, 701 },
700 702
701 __proto__: WebInspector.Object.prototype 703 __proto__: WebInspector.Object.prototype
702 } 704 }
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
1045 this.asyncStackTrace.dispose(); 1047 this.asyncStackTrace.dispose();
1046 }, 1048 },
1047 1049
1048 __proto__: WebInspector.TargetAware.prototype 1050 __proto__: WebInspector.TargetAware.prototype
1049 } 1051 }
1050 1052
1051 /** 1053 /**
1052 * @type {!WebInspector.DebuggerModel} 1054 * @type {!WebInspector.DebuggerModel}
1053 */ 1055 */
1054 WebInspector.debuggerModel; 1056 WebInspector.debuggerModel;
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/HandlerRegistry.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698