Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 213423009: [CSS Grid Layout] Remove unused variable in test (Closed)

Created:
6 years, 9 months ago by Manuel Rego
Modified:
6 years, 9 months ago
CC:
blink-reviews, svillar, jfernandez, Manuel Rego
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] Remove unused variable in test Inside method updateImplicitGridColumn() of test fast/css-grid-layout/implicit-position-dynamic-change.html we define a variable gridItem that is not used. This patch removes it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M LayoutTests/fast/css-grid-layout/implicit-position-dynamic-change.html View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Manuel Rego
6 years, 9 months ago (2014-03-27 11:44:37 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-27 12:01:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/213423009/1
6 years, 9 months ago (2014-03-27 12:01:20 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 13:11:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 13:11:53 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-27 13:20:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/213423009/1
6 years, 9 months ago (2014-03-27 13:20:21 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:26:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 14:26:53 UTC) #9
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 9 months ago (2014-03-27 14:38:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/213423009/1
6 years, 9 months ago (2014-03-27 14:38:12 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:58:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 14:58:48 UTC) #13
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 9 months ago (2014-03-27 21:52:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/213423009/1
6 years, 9 months ago (2014-03-27 21:52:50 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:07:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 23:07:53 UTC) #17
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 9 months ago (2014-03-28 08:11:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/213423009/1
6 years, 9 months ago (2014-03-28 08:11:19 UTC) #19
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 09:14:02 UTC) #20
Message was sent while issue was closed.
Change committed as 170301

Powered by Google App Engine
This is Rietveld 408576698