Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2134223003: [gn] Add file needed for gn on mac to run (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Add file needed for gn on mac to run BUG=chromium:474921, chromium:626064 Committed: https://crrev.com/c70dc6acd7d3a7319277edd41740ce0e5926ad8d Cr-Commit-Position: refs/heads/master@{#37679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A build_overrides/build.gni View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Achenbach
PTAL. This ports https://cs.chromium.org/chromium/src/build_overrides/build.gni
4 years, 5 months ago (2016-07-11 15:09:44 UTC) #3
vogelheim
lgtm
4 years, 5 months ago (2016-07-12 13:02:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134223003/1
4 years, 5 months ago (2016-07-12 13:18:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 13:21:02 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 13:22:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c70dc6acd7d3a7319277edd41740ce0e5926ad8d
Cr-Commit-Position: refs/heads/master@{#37679}

Powered by Google App Engine
This is Rietveld 408576698