Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2134153002: Roll Webkit DEPS to fix layout test status (Closed)

Created:
4 years, 5 months ago by Bill Hesse
Modified:
4 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Also revert 323ca7e410765f98a88d078c8c8c388fd972eba9 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1313 lines, -2648 lines) Patch
M CHANGELOG.md View 1 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/util/fast_uri.dart View 1 1 chunk +17 lines, -1 line 0 comments Download
M runtime/lib/uri_patch.dart View 1 1 chunk +4 lines, -6 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 1 chunk +3 lines, -5 lines 0 comments Download
M sdk/lib/core/uri.dart View 1 38 chunks +1283 lines, -2387 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/data_uri_test.dart View 1 2 chunks +0 lines, -15 lines 0 comments Download
M tests/corelib/uri_test.dart View 1 4 chunks +4 lines, -229 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 5 months ago (2016-07-11 10:47:08 UTC) #2
Johnni Winther
lgtm
4 years, 5 months ago (2016-07-11 10:49:38 UTC) #3
Bill Hesse
4 years, 5 months ago (2016-07-11 10:55:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
373121fb71b89422c20776c4c17a1960eb8b99c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698