Issue 2134143002: [turbofan] Improve NumberAbs lowering for Signed32 input.

Issue 2134143002: [turbofan] Improve NumberAbs lowering for Signed32 input. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer

Modified:
4 years, 5 months ago

Reviewers:
Jarin

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Improve NumberAbs lowering for Signed32 input. We can just do the Int32Abs lowering always for Signed32 inputs. R=jarin@chromium.org Committed: https://crrev.com/6ade0ee308051eae471cce054f777f6fd2835213 Cr-Commit-Position: refs/heads/master@{#37638}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/compiler/simplified-lowering.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/type-cache.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 12 (6 generated)

Benedikt Meurer

Hey Jaro, Here's another low-hanging fruit. Please take a look. Thanks, Benedikt

4 years, 5 months ago (2016-07-11 11:25:13 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134143002/1

4 years, 5 months ago (2016-07-11 11:49:12 UTC) #9

commit-bot: I haz the power

4 years, 5 months ago (2016-07-11 11:51:41 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6ade0ee308051eae471cce054f777f6fd2835213
Cr-Commit-Position: refs/heads/master@{#37638}