Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2134133002: Introduce search::IsInstantNTPURL (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce search::IsInstantNTPURL and clean up the comments for IsNTPURL and IsInstantNTP to match what the functions actually do. BUG=624410 Committed: https://crrev.com/387415b57a38770553fdce23a538cb069fa94ca9 Cr-Commit-Position: refs/heads/master@{#404641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M chrome/browser/search/search.h View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/search/search.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Marc Treib
PTAL!
4 years, 5 months ago (2016-07-11 10:31:49 UTC) #4
Bryan McQuade
lgtm
4 years, 5 months ago (2016-07-11 12:08:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134133002/1
4 years, 5 months ago (2016-07-11 12:32:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 12:35:51 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 12:36:20 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 12:40:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/387415b57a38770553fdce23a538cb069fa94ca9
Cr-Commit-Position: refs/heads/master@{#404641}

Powered by Google App Engine
This is Rietveld 408576698