Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: third_party/WebKit/Source/core/frame/Frame.cpp

Issue 2134113002: Use ChildFrameDisconnector when detaching child frames of a LocalFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Frame.cpp
diff --git a/third_party/WebKit/Source/core/frame/Frame.cpp b/third_party/WebKit/Source/core/frame/Frame.cpp
index 4a92e164bf5bd996b929334dce55a695e24e30ff..1c763fee1b4523a7ba75d0d6ed6732b0f6607e4f 100644
--- a/third_party/WebKit/Source/core/frame/Frame.cpp
+++ b/third_party/WebKit/Source/core/frame/Frame.cpp
@@ -78,17 +78,6 @@ void Frame::detach(FrameDetachType type)
m_host = nullptr;
}
-void Frame::detachChildren()
-{
- typedef HeapVector<Member<Frame>> FrameVector;
- FrameVector childrenToDetach;
- childrenToDetach.reserveCapacity(tree().childCount());
- for (Frame* child = tree().firstChild(); child; child = child->tree().nextSibling())
- childrenToDetach.append(child);
- for (const auto& child : childrenToDetach)
- child->detach(FrameDetachType::Remove);
-}
-
void Frame::disconnectOwnerElement()
{
if (m_owner) {
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698