third_party/WebKit/Source/core/frame/LocalFrame.h - Issue 2134113002: Use ChildFrameDisconnector when detaching child frames of a LocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2134113002: Use ChildFrameDisconnector when detaching child frames of a LocalFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalFrame.h

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h

index 2165cca6ed38af5fcb3e928034ec644c8e86fc94..90c0adb6eb323719b43b3ebacee4f78a30acdac0 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.h

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h

@@ -104,6 +104,7 @@ public:

bool prepareForCommit() override;

void didChangeVisibilityState() override;

+ void detachChildren();

void willDetachFrameHost();

LocalDOMWindow* localDOMWindow() const;