Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: src/frames.h

Issue 2134093002: [builtins] Show builtin frames in PrintStack() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Print frame kind Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index b98f732f7d8ddbc8b82576e2031623311ffa0769..4be488620d1ef87c607aef3a5c310a2c171b1af8 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -670,13 +670,20 @@ class BuiltinExitFrame : public ExitFrame {
bool IsConstructor() const;
+ void Print(StringStream* accumulator, PrintMode mode,
+ int index) const override;
+
protected:
inline explicit BuiltinExitFrame(StackFrameIteratorBase* iterator);
private:
+ Object* GetParameter(int i) const;
+ int ComputeParametersCount() const;
+
+ inline Object* receiver_slot_object() const;
+ inline Object* argc_slot_object() const;
inline Object* target_slot_object() const;
inline Object* new_target_slot_object() const;
- inline Object* receiver_slot_object() const;
friend class StackFrameIteratorBase;
};
@@ -878,6 +885,8 @@ class JavaScriptFrame : public StandardFrame {
// receiver, and any callee-saved registers.
void IterateArguments(ObjectVisitor* v) const;
+ virtual void PrintFrameKind(StringStream* accumulator) const {}
+
private:
inline Object* function_slot_object() const;
@@ -1022,13 +1031,11 @@ class BuiltinFrame final : public JavaScriptFrame {
return static_cast<BuiltinFrame*>(frame);
}
- // Printing support.
- void Print(StringStream* accumulator, PrintMode mode, int index) const final;
-
protected:
inline explicit BuiltinFrame(StackFrameIteratorBase* iterator);
int GetNumberOfIncomingArguments() const final;
+ void PrintFrameKind(StringStream* accumulator) const override;
private:
friend class StackFrameIteratorBase;
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698