Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h

Issue 2134063002: Remove DOMWindowLifecycleObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h
diff --git a/third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h b/third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h
index 024e72418d4923da6eadfe9cda5f3d3fae0d2b02..52ab269ba3551d9224e6130005e34dac5368b17f 100644
--- a/third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h
+++ b/third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h
@@ -6,7 +6,7 @@
#define DOMWindowStorageController_h
#include "core/dom/Document.h"
-#include "core/frame/DOMWindowLifecycleObserver.h"
+#include "core/frame/LocalDOMWindow.h"
#include "modules/ModulesExport.h"
#include "platform/Supplementable.h"
#include "platform/heap/Handle.h"
@@ -16,7 +16,7 @@ namespace blink {
class Document;
class Event;
-class MODULES_EXPORT DOMWindowStorageController final : public GarbageCollected<DOMWindowStorageController>, public Supplement<Document>, public DOMWindowLifecycleObserver {
+class MODULES_EXPORT DOMWindowStorageController final : public GarbageCollected<DOMWindowStorageController>, public Supplement<Document>, public LocalDOMWindow::EventListenerObserver {
USING_GARBAGE_COLLECTED_MIXIN(DOMWindowStorageController);
public:
DECLARE_VIRTUAL_TRACE();
@@ -24,8 +24,10 @@ public:
static const char* supplementName();
static DOMWindowStorageController& from(Document&);
- // Inherited from DOMWindowLifecycleObserver
+ // Inherited from LocalDOMWindow::EventListenerObserver
void didAddEventListener(LocalDOMWindow*, const AtomicString&) override;
+ void didRemoveEventListener(LocalDOMWindow*, const AtomicString&) override { }
+ void didRemoveAllEventListeners(LocalDOMWindow*) override { }
protected:
explicit DOMWindowStorageController(Document&);

Powered by Google App Engine
This is Rietveld 408576698