Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 213403004: Revert of Move Event to oilpan's heap (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
CC:
blink-reviews, kouhei (in TOK)
Visibility:
Public.

Description

Revert of Move Event to oilpan's heap (https://codereview.chromium.org/208173004/) Reason for revert: Seems likely to have caused a number of flaky failures in layout tests in oilpan builds: Flakiness dashboard link: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=http%2Ftests%2Fmedia%2Fmedia-source%2Fwebkitmediasource-closed-on-htmlmediaelement-destruction.html%2Csvg%2Fanimations%2Fsmil-leak-element-instances-noBaseValRef.svg%2Csvg%2Fanimations%2Fsmil-leak-element-instances.svg%2Csvg%2Fanimations%2Fsmil-leak-elements.svg Example failure bot: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/builds/2770 Example failure: --- /mnt/data/b/build/slave/WebKit_Linux_Oilpan/build/layout-test-results/svg/animations/smil-leak-element-instances-noBaseValRef-expected.txt +++ /mnt/data/b/build/slave/WebKit_Linux_Oilpan/build/layout-test-results/svg/animations/smil-leak-element-instances-noBaseValRef-actual.txt @@ -1 +1 @@ -PASS +FAIL: -3 extra live node(s) Original issue's description: > Move Event to oilpan's heap > > Now there is no test failing when I change RefCounted<Event> to RefCountedGarbageCollected<Event>. Thus this CL does the change. > > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169941 TBR=oilpan-reviews@chromium.org,ager@chromium.org,wibling@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/events/Event.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
enne (OOO)
Created Revert of Move Event to oilpan's heap
6 years, 9 months ago (2014-03-26 20:17:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/213403004/1
6 years, 9 months ago (2014-03-26 20:17:29 UTC) #2
commit-bot: I haz the power
Change committed as 170092
6 years, 9 months ago (2014-03-26 20:18:32 UTC) #3
sof
Thanks for trying to clear out test failures. Taking out this particular change isn't complete, ...
6 years, 9 months ago (2014-03-26 20:29:07 UTC) #4
enne (OOO)
On 2014/03/26 20:29:07, sof wrote: > Thanks for trying to clear out test failures. > ...
6 years, 9 months ago (2014-03-26 20:30:34 UTC) #5
sof
On 2014/03/26 20:30:34, enne wrote: > On 2014/03/26 20:29:07, sof wrote: > > Thanks for ...
6 years, 9 months ago (2014-03-26 20:37:34 UTC) #6
enne (OOO)
I don't know much about oilpan at all. Just to make sure I'm on the ...
6 years, 9 months ago (2014-03-26 20:43:43 UTC) #7
sof
On 2014/03/26 20:43:43, enne wrote: > I don't know much about oilpan at all. Just ...
6 years, 9 months ago (2014-03-26 20:57:23 UTC) #8
enne (OOO)
6 years, 9 months ago (2014-03-26 22:59:31 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/213803002/ by enne@chromium.org.

The reason for reverting is: Original revert was too aggressive.  Failures are
just local to the test, and the original patch fixed bugs..

Powered by Google App Engine
This is Rietveld 408576698