Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2134023002: Valgrind: Remove obsolete WebSharedWorkerStub suppression. (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
shimazu
CC:
bruening+watch_chromium.org, chromium-reviews, glider+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Valgrind: Remove obsolete WebSharedWorkerStub suppression. This symbol no longer appears in the codebase. BUG=27837 Committed: https://crrev.com/8c3b0fc2a1ff143ab669300bc841327eaeb5b68b Cr-Commit-Position: refs/heads/master@{#404605}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -7 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
falken
PTAL https://codereview.chromium.org/2134023002/diff/1/tools/valgrind/memcheck/suppressions.txt File tools/valgrind/memcheck/suppressions.txt (left): https://codereview.chromium.org/2134023002/diff/1/tools/valgrind/memcheck/suppressions.txt#oldcode697 tools/valgrind/memcheck/suppressions.txt:697: # The following three suppressions are related to ...
4 years, 5 months ago (2016-07-11 04:18:23 UTC) #2
shimazu
lgtm
4 years, 5 months ago (2016-07-11 05:18:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134023002/1
4 years, 5 months ago (2016-07-11 05:33:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 06:22:47 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 06:22:50 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 06:24:20 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8c3b0fc2a1ff143ab669300bc841327eaeb5b68b
Cr-Commit-Position: refs/heads/master@{#404605}

Powered by Google App Engine
This is Rietveld 408576698