Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2134003002: service worker: Fix crash keys instrumentation. (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
dcheng
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Fix crash keys instrumentation. ScopedCrashKey(blah, blah) should be ScopedCrashKey key(blah, blah) BUG=625040 Committed: https://crrev.com/82ddef2733b94fd7900838244562169ad0c6d9c8 Cr-Commit-Position: refs/heads/master@{#404594}

Patch Set 1 #

Patch Set 2 : mt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
falken
4 years, 5 months ago (2016-07-11 01:32:04 UTC) #3
dcheng
lgtm
4 years, 5 months ago (2016-07-11 01:36:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134003002/20001
4 years, 5 months ago (2016-07-11 01:36:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 03:38:57 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 03:40:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82ddef2733b94fd7900838244562169ad0c6d9c8
Cr-Commit-Position: refs/heads/master@{#404594}

Powered by Google App Engine
This is Rietveld 408576698