Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: tracing/tracing/value/ui/composition_span.html

Issue 2133963002: Implement Composition.buildFromEvents() (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/numeric.html ('k') | tracing/tracing/value/ui/diagnostic_span.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/composition_span.html
diff --git a/tracing/tracing/value/ui/composition_span.html b/tracing/tracing/value/ui/composition_span.html
index 786e73ebeb4907e6661a94842ec4f9e4efa933f8..7f424cd8335247c154330ebc208a0eb3eda341c7 100644
--- a/tracing/tracing/value/ui/composition_span.html
+++ b/tracing/tracing/value/ui/composition_span.html
@@ -17,9 +17,11 @@ found in the LICENSE file.
Polymer({
created: function() {
this.chart_ = new tr.ui.b.BarChart();
- this.chart_.width = 100;
- this.chart_.height = 50;
+ this.chart_.width = 190;
+ this.chart_.height = 200;
this.chart_.isStacked = true;
+ this.chart_.hideXAxis = true;
+ this.chart_.margin.right = 120;
},
ready: function() {
@@ -45,13 +47,16 @@ found in the LICENSE file.
var valueCount = 0;
this.diagnostic_.iterItems(function(name, value) {
++valueCount;
+ this.chart_.getDataSeries(name).target = value;
+ this.chart_.getDataSeries(name).optional = true;
+
value = value.numeric;
if (value instanceof tr.v.ScalarNumeric)
data[name] = value.value;
else if (value instanceof tr.v.Numeric)
data[name] = value.sum;
- });
- this.chart_.height = 50 + (50 * valueCount);
+
+ }, this);
this.chart_.data = [data];
}
});
« no previous file with comments | « tracing/tracing/value/numeric.html ('k') | tracing/tracing/value/ui/diagnostic_span.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698