Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: tracing/tracing/ui/base/pie_chart.html

Issue 2133963002: Implement Composition.buildFromEvents() (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/base/name_bar_chart.html ('k') | tracing/tracing/ui/base/table.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/pie_chart.html
diff --git a/tracing/tracing/ui/base/pie_chart.html b/tracing/tracing/ui/base/pie_chart.html
index 7bacd583670ff35b750c176cf659725a103b261e..d9c5fd4a7af3d006414a48b02f3b3b9cec85afc9 100644
--- a/tracing/tracing/ui/base/pie_chart.html
+++ b/tracing/tracing/ui/base/pie_chart.html
@@ -30,6 +30,7 @@ tr.exportTo('tr.ui.b', function() {
decorate: function() {
ChartBase.prototype.decorate.call(this);
+ this.margin.top = 0;
this.classList.add('pie-chart');
this.data_ = undefined;
@@ -54,6 +55,9 @@ tr.exportTo('tr.ui.b', function() {
return this.data_;
},
+ get titleMarginPx() {
+ return 40;
+ },
/**
* @param {Array} data Data for the chart, where each element in the array
@@ -80,13 +84,6 @@ tr.exportTo('tr.ui.b', function() {
this.updateContents_();
},
- get margin() {
- var margin = {top: 0, right: 0, bottom: 0, left: 0};
- if (this.chartTitle_)
- margin.top += 40;
- return margin;
- },
-
getMinSize: function() {
this.updateContents_();
« no previous file with comments | « tracing/tracing/ui/base/name_bar_chart.html ('k') | tracing/tracing/ui/base/table.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698