Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 213393002: Mojo: Move public C system header files to mojo/public/c/system/. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Move public C system header files to mojo/public/c/system/. (macros.h is a bit strange, since it contains C++ macros as well. We may want to split this file.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259742

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -1058 lines) Patch
M mojo/apps/js/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/mojo_runner_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/waiting_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/embedder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/default_async_waiter_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/view_manager/view_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/mojo_public.gypi View 1 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/bindings/allocation_scope.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/fixed_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/message_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/scratch_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/remote_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/connector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/c/system/async_waiter.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/c/system/core.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/public/c/system/macros.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/c/system/system_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/environment/default_async_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/environment/environment.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/environment/tests/async_waiter_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/gles2/gles2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/gles2/gles2_private.h View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/system/async_waiter.h View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/public/system/core.h View 1 chunk +0 lines, -829 lines 0 comments Download
M mojo/public/system/core_cpp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/system/core_private.h View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/system/macros.h View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/public/system/system_export.h View 1 chunk +0 lines, -26 lines 0 comments Download
M mojo/public/tests/system/core_cpp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tests/system/core_perftest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tests/system/core_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tests/system/core_unittest_pure_c.c View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/tests/system/macros_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/utility/lib/thread_local.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/mutex.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/tests/mutex_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/tests/thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/core_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/data_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/waiter_list.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/waiter_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-26 18:03:26 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/213393002/diff/1/mojo/public/c/system/macros.h File mojo/public/c/system/macros.h (right): https://codereview.chromium.org/213393002/diff/1/mojo/public/c/system/macros.h#newcode31 mojo/public/c/system/macros.h:31: #ifdef __cplusplus I guess we can just have ...
6 years, 9 months ago (2014-03-26 18:07:19 UTC) #2
viettrungluu
On 2014/03/26 18:07:19, darin wrote: > LGTM > > https://codereview.chromium.org/213393002/diff/1/mojo/public/c/system/macros.h > File mojo/public/c/system/macros.h (right): > ...
6 years, 9 months ago (2014-03-26 18:18:31 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-26 19:24:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/213393002/20001
6 years, 9 months ago (2014-03-26 19:24:14 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 23:52:13 UTC) #6
Message was sent while issue was closed.
Change committed as 259742

Powered by Google App Engine
This is Rietveld 408576698