Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3653)

Unified Diff: chrome/android/webapk/libs/runtime_library/BUILD.gn

Issue 2133923002: Simplify caller checking logic in WebApkServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into sandbox_on_transact1 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/libs/runtime_library/BUILD.gn
diff --git a/chrome/android/webapk/libs/runtime_library/BUILD.gn b/chrome/android/webapk/libs/runtime_library/BUILD.gn
index 705ebb0f0ce2b1ad28b89a7ccdfa7ec9669c174b..b24cd068780034ddef05f9a072c1e1ced9676df5 100644
--- a/chrome/android/webapk/libs/runtime_library/BUILD.gn
+++ b/chrome/android/webapk/libs/runtime_library/BUILD.gn
@@ -22,7 +22,8 @@ android_aidl("webapk_service_aidl") {
}
android_library("runtime_library_java") {
- dex_path = "$target_gen_dir/$runtime_library_dex_asset_name"
+ # The dx tool expects files ending in .dex.jar
+ dex_path = "$target_gen_dir/$runtime_library_dex_asset_name.jar"
java_files = [
"src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java",
"src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java",
@@ -37,9 +38,10 @@ android_assets("runtime_library_assets") {
write_file("$target_gen_dir/webapk_dex_version.txt", runtime_library_version)
sources = [
- "$target_gen_dir/$runtime_library_dex_asset_name",
"$target_gen_dir/webapk_dex_version.txt",
]
+ renaming_sources = [ "$target_gen_dir/$runtime_library_dex_asset_name.jar" ]
+ renaming_destinations = [ "$runtime_library_dex_asset_name" ]
disable_compression = true
deps = [
@@ -47,10 +49,13 @@ android_assets("runtime_library_assets") {
]
}
-junit_binary("webapk_runtime_library_junit_tests") {
- java_files = [ "junit/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java" ]
+android_library("runtime_library_javatests") {
+ testonly = true
+ java_files = [ "javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java" ]
deps = [
":runtime_library_java",
- "//base:base_junit_test_support",
+ "//base:base_java_test_support",
+ "//chrome/test/android:chrome_java_test_support",
+ "//content/public/test/android:content_java_test_support",
]
}

Powered by Google App Engine
This is Rietveld 408576698