Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2133913002: dart2js: Reduce overhead of --verbose measurements (Closed)

Created:
4 years, 5 months ago by sra1
Modified:
4 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Reduce overhead of --verbose measurements ZoneSpecification and zoneValues are now per-task, rather than per measurement. This reduces total LinkedHashMap allocations by 30% In the large compile I am using to measure these things, there are still ~3M zones created via Zone.fork and 10M _ZoneFunction objects allocated, and the Zone.fork copies the (now cached) LinkedHashMap. So cross-task measurements are still quite expensive. R=ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/101a83f2f465edfa60b4e013ad53b0868ce99b89

Patch Set 1 #

Total comments: 1

Patch Set 2 : move fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M pkg/compiler/lib/src/common/tasks.dart View 1 2 chunks +43 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
Peter, what do you think?
4 years, 5 months ago (2016-07-09 01:39:26 UTC) #2
ahe
lgtm That's a neat idea. https://codereview.chromium.org/2133913002/diff/1/pkg/compiler/lib/src/common/tasks.dart File pkg/compiler/lib/src/common/tasks.dart (right): https://codereview.chromium.org/2133913002/diff/1/pkg/compiler/lib/src/common/tasks.dart#newcode106 pkg/compiler/lib/src/common/tasks.dart:106: ZoneSpecification _zoneSpecification; I would ...
4 years, 4 months ago (2016-08-04 17:17:33 UTC) #3
sra1
4 years, 4 months ago (2016-08-08 21:18:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
101a83f2f465edfa60b4e013ad53b0868ce99b89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698