Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4689)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 2133893002: [MD settings] disable clear browsing data while it is running (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h
index 24d8c49922fddb14ddad4c5da5ebba98038b2629..b699aff06df1a8225006bd9e8d1004a8f0899301 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.h
+++ b/chrome/browser/browsing_data/browsing_data_remover.h
@@ -173,11 +173,19 @@ class BrowsingDataRemover : public KeyedService
base::Time end;
};
- // Observer is notified when the removal is done. Done means keywords have
- // been deleted, cache cleared and all other tasks scheduled.
+ // Observer is notified when the removal is active and when it's done.
class Observer {
public:
- virtual void OnBrowsingDataRemoverDone() = 0;
+ // NOTE: DEPRECATED; talk to dbeam/msramek before using this.
+ //
+ // Whether removal is active. Note that not having an active removal is not
+ // same as completing a removal. That is why the removing status is separate
+ // from the done message.
+ virtual void OnBrowsingDataRemoving(bool is_removing) {}
+
+ // Done means keywords have been deleted, cache cleared and all other
+ // removal tasks are scheduled.
+ virtual void OnBrowsingDataRemoverDone() {}
protected:
virtual ~Observer() {}
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698